From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, victortoso@redhat.com
Subject: Re: [PATCH] Revert "qapi: fix examples of blockdev-add with qcow2"
Date: Wed, 5 Oct 2022 11:58:35 +0200 [thread overview]
Message-ID: <Yz1VS9h9MxRQFZkn@redhat.com> (raw)
In-Reply-To: <20220930171908.846769-1-armbru@redhat.com>
Am 30.09.2022 um 19:19 hat Markus Armbruster geschrieben:
> This reverts commit b6522938327141235b97ab38e40c6c4512587373.
>
> Kevin Wolf NAKed this patch, because:
>
> 'file' is a required member (defined in BlockdevOptionsGenericFormat),
> removing it makes the example invalid. 'data-file' is only an additional
> optional member to be used for external data files (i.e. when the guest
> data is kept separate from the metadata in the .qcow2 file).
>
> However, it had already been merged then. Revert.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2022-10-05 10:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 17:19 [PATCH] Revert "qapi: fix examples of blockdev-add with qcow2" Markus Armbruster
2022-10-04 8:13 ` Victor Toso
2022-10-04 12:21 ` Victor Toso
2022-10-05 9:58 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz1VS9h9MxRQFZkn@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=victortoso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).