From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 02C88C6FA83 for ; Tue, 27 Sep 2022 17:35:20 +0000 (UTC) Received: from localhost ([::1]:49682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odD54-0007s4-A7 for qemu-devel@archiver.kernel.org; Tue, 27 Sep 2022 12:05:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odClu-0002uI-F3 for qemu-devel@nongnu.org; Tue, 27 Sep 2022 11:45:28 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:51235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odClq-0007me-8p for qemu-devel@nongnu.org; Tue, 27 Sep 2022 11:45:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664293517; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pnU/nmJSY6AYxri7fygiuAn7sBox+V0YKLPmkrJPyPw=; b=ObKX+WjO8TfL+jaUlHdV2sTILZwmQMkezMrkLnkq7OdINqHF9jejP94VlkSrs9sZF1jGnF oehMETskurau4EF6KBzURfuMDb3gj2eHF5ZeRMHI0AJV9PwXnbDXkJsg4qM5MNe2SD+ics fIFjrbWQz/bB49AXOy3XZOdhcbFAnDI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-53-FycC9Tv5Pi-OB6faUpxHUw-1; Tue, 27 Sep 2022 11:45:13 -0400 X-MC-Unique: FycC9Tv5Pi-OB6faUpxHUw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 732DD811728; Tue, 27 Sep 2022 15:45:13 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.77]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2EFB540C6EC3; Tue, 27 Sep 2022 15:45:12 +0000 (UTC) Date: Tue, 27 Sep 2022 16:45:09 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Ani Sinha Cc: "Michael S. Tsirkin" , imammedo@redhat.com, jsnow@redhat.com, pbonzini@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org, thuth@redhat.com Subject: Re: [PATCH v2 07/11] acpi/tests/bits: add python test that exercizes QEMU bios tables using biosbits Message-ID: References: <20220917162606-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.6 (2022-06-05) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Sep 27, 2022 at 07:35:13PM +0530, Ani Sinha wrote: > On Tue, Sep 27, 2022 at 5:12 PM Ani Sinha wrote: > > > > On Tue, Sep 27, 2022 at 3:48 PM Daniel P. Berrangé wrote: > > > > > > On Tue, Sep 27, 2022 at 03:37:39PM +0530, Ani Sinha wrote: > > > > > > > > > > > > > > > > > > > > OK fine. Lets figuire out how to push bits somewhere in git.qemu.org and > > > > > > > > > > the binaries in some other repo first. Everything else hinges on that. We > > > > > > > > > > can fix the rest of the bits later incrementally. > > > > > > > > > > > > > > > > > > DanPB, any thoughts on putting bits on git.qemu.org or where and how to > > > > > > > > > keep the binaries? > > > > > > > > > > > > > > > > Can we please conclude on this? > > > > > > > > Peter, can you please fork the repo? I have tried many times to reach > > > > > > > > you on IRC but failed. > > > > > > > > > > > > > > Probably because of travel around KVM forum. > > > > > > > > > > > > > > I think given our CI is under pressure again due to gitlab free tier > > > > > > > limits, tying binaries to CI isn't a great idea at this stage. > > > > > > > Can Ani just upload binaies to qemu.org for now? > > > > > > > > > > > > I agree with Michael here. Having a full ci/cd job for this is > > > > > > overkill IMHO. We should create a repo just for the binaries, have a > > > > > > README there to explain how we generate them and check in new versions > > > > > > as and when needed (it won't be frequent). > > > > > > How about biosbits-bin repo? > > > > > > > > > > If QEMU is hosting binaries, where any part contains GPL code, then we > > > > > need to be providing the full and corresponding source and the build > > > > > scripts needed to re-create the binary. Once we have such scripts it > > > > > should be trivial to trigger that from a CI job. If it isn't then > > > > > we're doing something wrong. > > > > > > > > I was thinking of commiting the build scripts in a branch of > > > > https://gitlab.com/qemu-project/biosbits-bits. > > > > This would separate them from the main source. The scripts would build > > > > a version of qemu-bits based on the version information passed to it > > > > from the environment. > > > > Before I committed the scripts, I wanted to check whether we would > > > > want to do that or have a separate repo containing the binaries and > > > > the build scripts. > > > > Seems we want the former. > > > > > > > > As for the gitlab-ci, I looked at the yaml file and the qemu ones > > > > looks quite complicated. Can someone help me generate one based on the > > > > build script here? > > > > https://github.com/ani-sinha/bits/blob/bits-qemu-logging/build-artifacts.sh > > > > > > Yes, QEMU's rules aren't a good place to start if you're trying > > > to learn gitlab CI, as they're very advanced. > > > > > > The simple case though is quite simple. > > > > > > * You need a container image to act as the build env > > > * In 'before_script' install any packages you need on top of the > > > base container image for build deps > > > * In 'script' run whatever shell commands you need in order > > > to build the project > > > * Add an 'artifacts' section to publish one (or more) files/dirs > > > as output > > > > > > The simplest example would be something like > > > > > > mybuild: > > > image: fedora:36 > > > before_script: > > > - dnf install -y gcc > > > script: > > > - gcc -o myapp myapp.c > > > artifacts > > > paths: > > > - myapp > > > > > > > How does this look? > > https://pastebin.com/0YyLFmi3 > > Alright, .gitlab-ci.yml is produced and the pipeline succeeds. > However, the question still remains, where do we keep the generated > artifacts? The following link will always reflect the published artifacts from the most recently fully successful CI pipeline, on the 'qemu-bits' branch, and 'qemu-bits-build' CI job: https://gitlab.com/qemu-project/biosbits-bits/-/jobs/artifacts/qemu-bits/download?job=qemu-bits-build Tweak as needed if you push the CI to master branch instead. This link can be considered the permanent home of the artifact. I'd just suggest that the QEMU job automatically skip if it fails to download the artifact, as occassionally transient infra errors can impact it. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|