From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64933C369A2 for ; Thu, 10 Apr 2025 02:23:29 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u2hXH-0005J3-Oz; Wed, 09 Apr 2025 22:20:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u2hXD-0005HY-Jy; Wed, 09 Apr 2025 22:20:57 -0400 Received: from mgamail.intel.com ([192.198.163.11]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u2hXB-0000qw-Ha; Wed, 09 Apr 2025 22:20:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744251654; x=1775787654; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=N/CZ9fUsPlUSKuyUXcdSU3b8XXzkRmBDT3dSqkO2yL0=; b=MtF6geJ5YKqC4Bph5o/C9+cZdZiVEQikmIDcyLYXvNBJVPlvPG5gYXIK olYIMHpgWGjhBja1f7O0THiqg6mxhyru5Ua+6SgWu2/w0BYowOcvqUQOy +wNx4Lod59UgXa6TIV/KrV/OtYtCfuQBkFO43CBzDZjkaLlvA0TrveTnY CPevpZnCTAKtVqwZ9w/LZcyOXFBZluGvJobZhffdqrVUbb8RnpmlT+jtC BvpmHQFnnIuajrALnvy3HU/LZ/O1riR3oy7IGZvBRWVUEJV69GqXIOJZV 5q1wWhYmdKFsDVaRkIM4rRRESbpemEdG+xFVtWo9VIb3CQoHbVzupPVok w==; X-CSE-ConnectionGUID: KB05lRf6SB+CSEpoCJLf4w== X-CSE-MsgGUID: +Ff0PVmDSEag9e5juLTrWQ== X-IronPort-AV: E=McAfee;i="6700,10204,11399"; a="56418582" X-IronPort-AV: E=Sophos;i="6.15,201,1739865600"; d="scan'208";a="56418582" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2025 19:20:47 -0700 X-CSE-ConnectionGUID: bKFIMmGZTHaJskCfi9AWxQ== X-CSE-MsgGUID: 2Y5avAX7QIGpzHaRBG2jdQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,201,1739865600"; d="scan'208";a="151936000" Received: from liuzhao-optiplex-7080.sh.intel.com (HELO localhost) ([10.239.160.39]) by fmviesa002.fm.intel.com with ESMTP; 09 Apr 2025 19:20:38 -0700 Date: Thu, 10 Apr 2025 10:41:27 +0800 From: Zhao Liu To: Dongli Zhang Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org, pbonzini@redhat.com, mtosatti@redhat.com, sandipan.das@amd.com, babu.moger@amd.com, likexu@tencent.com, like.xu.linux@gmail.com, groug@kaod.org, khorenko@virtuozzo.com, alexander.ivanov@virtuozzo.com, den@virtuozzo.com, davydov-max@yandex-team.ru, xiaoyao.li@intel.com, dapeng1.mi@linux.intel.com, joe.jin@oracle.com, peter.maydell@linaro.org, gaosong@loongson.cn, chenhuacai@kernel.org, philmd@linaro.org, aurelien@aurel32.net, jiaxun.yang@flygoat.com, arikalo@gmail.com, npiggin@gmail.com, danielhb413@gmail.com, palmer@dabbelt.com, alistair.francis@wdc.com, liwei1518@gmail.com, zhiwei_liu@linux.alibaba.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com, richard.henderson@linaro.org, david@redhat.com, iii@linux.ibm.com, thuth@redhat.com, flavra@baylibre.com, ewanhai-oc@zhaoxin.com, ewanhai@zhaoxin.com, cobechen@zhaoxin.com, louisqi@zhaoxin.com, liamni@zhaoxin.com, frankzhu@zhaoxin.com, silviazhao@zhaoxin.com Subject: Re: [PATCH v3 05/10] target/i386/kvm: extract unrelated code out of kvm_x86_build_cpuid() Message-ID: References: <20250331013307.11937-1-dongli.zhang@oracle.com> <20250331013307.11937-6-dongli.zhang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250331013307.11937-6-dongli.zhang@oracle.com> Received-SPF: pass client-ip=192.198.163.11; envelope-from=zhao1.liu@intel.com; helo=mgamail.intel.com X-Spam_score_int: -48 X-Spam_score: -4.9 X-Spam_bar: ---- X-Spam_report: (-4.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.505, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sun, Mar 30, 2025 at 06:32:24PM -0700, Dongli Zhang wrote: > Date: Sun, 30 Mar 2025 18:32:24 -0700 > From: Dongli Zhang > Subject: [PATCH v3 05/10] target/i386/kvm: extract unrelated code out of > kvm_x86_build_cpuid() > X-Mailer: git-send-email 2.43.5 > > The initialization of 'has_architectural_pmu_version', > 'num_architectural_pmu_gp_counters', and > 'num_architectural_pmu_fixed_counters' is unrelated to the process of > building the CPUID. > > Extract them out of kvm_x86_build_cpuid(). > > In addition, use cpuid_find_entry() instead of cpu_x86_cpuid(), because > CPUID has already been filled at this stage. > > Signed-off-by: Dongli Zhang > --- > Changed since v1: > - Still extract the code, but call them for all CPUs. > Changed since v2: > - Use cpuid_find_entry() instead of cpu_x86_cpuid(). > - Didn't add Reviewed-by from Dapeng as the change isn't minor. > > target/i386/kvm/kvm.c | 62 ++++++++++++++++++++++++------------------- > 1 file changed, 35 insertions(+), 27 deletions(-) Reviewed-by: Zhao Liu