Re: [PATCH v8 05/28] vfio: add vfio_prepare_device()

[John Levon <levon@movementarian.org>]

On Thu, Apr 03, 2025 at 11:19:34AM +0200, Cédric Le Goater wrote:

> On 2/19/25 15:48, John Levon wrote:
> > Commonize some initialization code shared by the legacy and iommufd vfio
> > implementations (and later by vfio-user).
> > 
> > Signed-off-by: John Levon <john.levon@nutanix.com>
> > ---
> >   hw/vfio/common.c              | 19 +++++++++++++++++++
> >   hw/vfio/container.c           | 14 +-------------
> >   hw/vfio/iommufd.c             |  9 +--------
> >   include/hw/vfio/vfio-common.h |  2 ++
> >   4 files changed, 23 insertions(+), 21 deletions(-)
> > 
> > diff --git a/hw/vfio/common.c b/hw/vfio/common.c
> > index eefd735bc6..4434e0a0a2 100644
> > --- a/hw/vfio/common.c
> > +++ b/hw/vfio/common.c
> > @@ -1569,6 +1569,25 @@ retry:
> >       return info;
> >   }
> > +void vfio_prepare_device(VFIODevice *vbasedev, VFIOContainerBase *bcontainer,
> > +                         VFIOGroup *group, struct vfio_device_info *info)
> 
> I would prefer that the first version did not have a 'group' parameter.
> Let's add it when needed.

I think you mean something like this in hw/vfio/container.c:

vfio_prepare_device(vbasedev, &group->container->bcontainer, info);

vbasedev->group = group;
QLIST_INSERT_HEAD(&group->device_list, vbasedev, next);

As it's the only consumer that actually wants a group.

thanks
john