From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 442EFC28B20 for ; Wed, 2 Apr 2025 10:54:23 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tzvjO-0004JR-1p; Wed, 02 Apr 2025 06:54:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tzvjL-0004Ip-Jq for qemu-devel@nongnu.org; Wed, 02 Apr 2025 06:53:59 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tzvjJ-0006j1-NW for qemu-devel@nongnu.org; Wed, 02 Apr 2025 06:53:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743591237; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YNbYiDQpgh83xT4o+zXH88rS/rt47eCQr5uZAYWa4VQ=; b=bVl8WQxjp/06YyL/GIQHarmDN2Geb+FrHvoD019uQcvLqM7G0SftWL9HP59qCT8tYNuWA8 Ofjv7mb+CZWHoA90brHnHk2uLkTj6dvV0MasssPzXgVtIv6BjGglbukQojIrZ+T27SIGU0 mt0Xx53V57CizRYxeImKtpjOFAM6TFU= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-48-282vzhoIO8CE9e87lgy1Zw-1; Wed, 02 Apr 2025 06:53:55 -0400 X-MC-Unique: 282vzhoIO8CE9e87lgy1Zw-1 X-Mimecast-MFC-AGG-ID: 282vzhoIO8CE9e87lgy1Zw_1743591234 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5228A19560AE; Wed, 2 Apr 2025 10:53:54 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.12]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E0389180176C; Wed, 2 Apr 2025 10:53:50 +0000 (UTC) Date: Wed, 2 Apr 2025 11:53:47 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Xiaoyao Li Cc: Paolo Bonzini , "Michael S. Tsirkin" , Markus Armbruster , Francesco Lavra , Marcelo Tosatti , qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Rick Edgecombe Subject: Re: [PATCH v8 02/55] i386: Introduce tdx-guest object Message-ID: References: <20250401130205.2198253-1-xiaoyao.li@intel.com> <20250401130205.2198253-3-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250401130205.2198253-3-xiaoyao.li@intel.com> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.153, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Apr 01, 2025 at 09:01:12AM -0400, Xiaoyao Li wrote: > Introduce tdx-guest object which inherits X86_CONFIDENTIAL_GUEST, > and will be used to create TDX VMs (TDs) by > > qemu -machine ...,confidential-guest-support=tdx0 \ > -object tdx-guest,id=tdx0 > > It has one QAPI member 'attributes' defined, which allows user to set > TD's attributes directly. > > Signed-off-by: Xiaoyao Li > Acked-by: Gerd Hoffmann > Acked-by: Markus Armbruster > --- > Changes in v7: > - update QAPI version to 10.0; > - update to use SPDX tags for license info; > - update copyright to 2025; > > Chanegs in v6: > - Make tdx-guest inherits X86_CONFIDENTIAL_GUEST; > - set cgs->require_guest_memfd; > - allow attributes settable via QAPI; > - update QAPI version to since 9.2; > > Changes in v4: > - update the new qapi `since` filed from 8.2 to 9.0 > > Changes in v1 > - make @attributes not user-settable > --- > configs/devices/i386-softmmu/default.mak | 1 + > hw/i386/Kconfig | 5 +++ > qapi/qom.json | 15 +++++++++ > target/i386/kvm/meson.build | 2 ++ > target/i386/kvm/tdx.c | 43 ++++++++++++++++++++++++ > target/i386/kvm/tdx.h | 21 ++++++++++++ > 6 files changed, 87 insertions(+) > create mode 100644 target/i386/kvm/tdx.c > create mode 100644 target/i386/kvm/tdx.h Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|