From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AF2ED10DCF for ; Mon, 2 Dec 2024 09:23:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tI2dw-00010H-JG; Mon, 02 Dec 2024 04:23:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI2dk-0000zM-QM for qemu-devel@nongnu.org; Mon, 02 Dec 2024 04:22:48 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI2dj-0000lm-AF for qemu-devel@nongnu.org; Mon, 02 Dec 2024 04:22:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733131365; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oPvtYQ44dFiDxXEHp0NjW7VnxSbZJlfKS4nawUzpwQc=; b=WwL5cXKFQugfcVAmclm0ADacI0tppPnSi45iUU2NHwhtg6dyLibft775VexVDCpWodbYyy Zoo+r7ZBBRoa14tt2f9A4zRh8/WBAgvbPZMfpAR8VHlj0CGRiwG5Ptm0VncI3XbhFI0ldo S1IvhvUMifG4ywgV/lGae91U1bes1p4= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-244-yY9ha75wMiuVMxM40v8o7Q-1; Mon, 02 Dec 2024 04:22:42 -0500 X-MC-Unique: yY9ha75wMiuVMxM40v8o7Q-1 X-Mimecast-MFC-AGG-ID: yY9ha75wMiuVMxM40v8o7Q Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B19C31944DDF; Mon, 2 Dec 2024 09:22:39 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.143]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D24B319560A3; Mon, 2 Dec 2024 09:22:37 +0000 (UTC) Date: Mon, 2 Dec 2024 09:22:34 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH 02/22] tests/functional: remove unused system imports Message-ID: References: <20241129173120.761728-1-berrange@redhat.com> <20241129173120.761728-3-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sat, Nov 30, 2024 at 10:59:55AM +0100, Thomas Huth wrote: > On 29/11/2024 18.31, Daniel P. Berrangé wrote: > > Signed-off-by: Daniel P. Berrangé > > --- > > tests/functional/test_aarch64_sbsaref.py | 1 - > > tests/functional/test_acpi_bits.py | 1 - > > tests/functional/test_m68k_mcf5208evb.py | 2 -- > > tests/functional/test_microblaze_s3adsp1800.py | 1 - > > tests/functional/test_mips64el_loongson3v.py | 1 - > > tests/functional/test_or1k_sim.py | 2 -- > > tests/functional/test_s390x_topology.py | 1 - > > tests/functional/test_sh4_tuxrun.py | 4 ---- > > tests/functional/test_sh4eb_r2d.py | 1 - > > tests/functional/test_virtio_version.py | 2 -- > > 10 files changed, 16 deletions(-) > > Out of curiosity: Is there a way to check for this with a program, or did > you check it manually? IIRC, pylint can check this sort of thing, but I performed a horror show with grep, sed and awk. We really ought to get black, pylint, flake8, integrated into meson.build, so we can add checks to python code around the tree more easily. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|