From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58612D7830E for ; Mon, 2 Dec 2024 11:45:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tI4rk-0002sO-9A; Mon, 02 Dec 2024 06:45:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI4ri-0002lN-FT for qemu-devel@nongnu.org; Mon, 02 Dec 2024 06:45:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tI4rg-0007SF-RM for qemu-devel@nongnu.org; Mon, 02 Dec 2024 06:45:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733139917; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LANGyCe7f6UWCVjY3IlJ1GbdYOD8ChCo6l/jr9n8B50=; b=aDZcrCx3abknoa0o/gCFfqfk63AyBBsZZtp/CHWV1y7I1gwcCvkLnLwKhW6nJXEYCxXd3t moC/mI8VoRXPIlZeY5/qNPZ7+X9xacRj/0HHTR77dzl+TgxLwb8BnBkm7Vss7abK3hCoIC BH+O1k5d32QnKEK3FELGYbNrLOoqd1A= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-_4IZvtemPd6THHrRC5O1xA-1; Mon, 02 Dec 2024 06:45:15 -0500 X-MC-Unique: _4IZvtemPd6THHrRC5O1xA-1 X-Mimecast-MFC-AGG-ID: _4IZvtemPd6THHrRC5O1xA Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F35C81964CDA; Mon, 2 Dec 2024 11:45:13 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.143]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D39831955E98; Mon, 2 Dec 2024 11:45:06 +0000 (UTC) Date: Mon, 2 Dec 2024 11:45:03 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Richard Henderson Cc: qemu-devel@nongnu.org, Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH 05/22] tests/functional: remove duplicated 'which' function impl Message-ID: References: <20241129173120.761728-1-berrange@redhat.com> <20241129173120.761728-6-berrange@redhat.com> <0c4fc00b-d016-4e12-8c0b-370c392c09eb@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0c4fc00b-d016-4e12-8c0b-370c392c09eb@linaro.org> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Sat, Nov 30, 2024 at 09:08:21AM -0600, Richard Henderson wrote: > On 11/29/24 11:31, Daniel P. Berrangé wrote: > > Put the 'which' function into shared code. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > tests/functional/qemu_test/__init__.py | 2 +- > > tests/functional/qemu_test/cmd.py | 10 ++++++++++ > > tests/functional/test_acpi_bits.py | 13 +------------ > > tests/functional/test_ppc64_hv.py | 13 +------------ > > 4 files changed, 13 insertions(+), 25 deletions(-) > > As code movement, > Reviewed-by: Richard Henderson > > > +def which(tool): > > + """ looks up the full path for @tool, returns None if not found > > + or if @tool does not have executable permissions. > > + """ > > + paths=os.getenv('PATH') > > + for p in paths.split(os.path.pathsep): > > + p = os.path.join(p, tool) > > + if os.path.exists(p) and os.access(p, os.X_OK): > > But surely exists() is redundant with access()? Agreed, will simplify that. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|