From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42A41E64AAA for ; Tue, 3 Dec 2024 13:54:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tITLz-000424-3H; Tue, 03 Dec 2024 08:54:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tITLu-00040u-3C for qemu-devel@nongnu.org; Tue, 03 Dec 2024 08:54:11 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tITLq-0003T7-KJ for qemu-devel@nongnu.org; Tue, 03 Dec 2024 08:54:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733234045; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yhf6vKfgiOjErrRtdomSDXJUj4SNPaZqKmr7a9f5CZc=; b=gGykN1Na22xgPkk3z3MYeptljHSybdFGiLsh1vXWXBPpvjjaxLmtCieeWBkO9RvOlQE7os Wbg0jzJlrVhn3xtQSigoRWMw7NsSMqV34/XheUFXqFaGW/zMDgBZGiyC0h2LMXoGH9hvzm tHRHc3N1+sYJ8k6zI/y7Nei0cZrRu7k= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-4xHlZpe-MmmGCo1SiQA24A-1; Tue, 03 Dec 2024 08:54:03 -0500 X-MC-Unique: 4xHlZpe-MmmGCo1SiQA24A-1 X-Mimecast-MFC-AGG-ID: 4xHlZpe-MmmGCo1SiQA24A Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED0DB1955D79; Tue, 3 Dec 2024 13:54:01 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.37]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9A5E91956089; Tue, 3 Dec 2024 13:54:00 +0000 (UTC) Date: Tue, 3 Dec 2024 13:53:57 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Alex =?utf-8?Q?Benn=C3=A9e?= Subject: Re: [PATCH 08/22] tests/functional: add helpers for building file paths Message-ID: References: <20241129173120.761728-1-berrange@redhat.com> <20241129173120.761728-9-berrange@redhat.com> <7a10e700-67dc-4619-bf6e-76bac44e88cc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7a10e700-67dc-4619-bf6e-76bac44e88cc@redhat.com> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Dec 02, 2024 at 10:19:47AM +0100, Thomas Huth wrote: > On 29/11/2024 18.31, Daniel P. Berrangé wrote: > > Add helper methods that construct paths for > > > > * log files - to be preserved at the end of a test > > * scratch files - to be purged at the end of a test > > * build files - anything relative to the build root > > * data files - anything relative to the functional test source root > > * socket files - a short temporary dir to avoid UNIX socket limits > > > > These are to be used instead of direct access to the self.workdir, > > or self.logdir variables, or any other place where paths are built > > manually. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > tests/functional/qemu_test/testcase.py | 86 ++++++++++++++++++++++++++ > > 1 file changed, 86 insertions(+) > > + ''' > > + def log_file(self, *args): > > + return str(Path(self.logdir, *args)) > > + > > def setUp(self, bin_prefix): > > self.assertIsNotNone(self.qemu_bin, 'QEMU_TEST_QEMU_BINARY must be set') > > self.arch = self.qemu_bin.split('-')[-1] > > + self.socketdir = None > > Should we also delete the socketdir during teardown again? Yes, we should be purging this object and deleting the dir With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|