From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
"Yong Huang" <yong.huang@smartx.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment
Date: Tue, 3 Dec 2024 12:40:06 -0500 [thread overview]
Message-ID: <Z09CdpY4C5Eq6OxI@x1n> (raw)
In-Reply-To: <8734j4kiuq.fsf@suse.de>
On Tue, Dec 03, 2024 at 10:15:57AM -0300, Fabiano Rosas wrote:
> We shouldn't be adding warnings to the build like that. When building
> static binaries, I'd assume the person at least knows there's a -static
> in there somewhere. If you're just building the system binaries and
> warnings start to show up, that's not good. Since this is just a side
> script that's very infrequently used, I don't think it justifies the
> extra warning.
Yeah this could be a valid point.
The main issue is I believe 99.999999% of people building qemu will not use
stress.c and the initrd at all. It means we could start burning some tiny
little more cpus all over the worlds for nothing.. the added warning is a
bad extra side effect of that.
So I wonder if it would make more sense to only build stress.c manually
like before, until some of the stress test would be put into either 'make
check' or CI flows. Then we decide whether to fix the warning or not.
--
Peter Xu
next prev parent reply other threads:[~2024-12-03 17:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 2:14 [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment yong.huang
2024-10-22 2:14 ` [PATCH v3 1/5] tests/migration: Move the guestperf tool to scripts directory yong.huang
2024-10-22 6:04 ` Prasad Pandit
2024-10-22 2:14 ` [PATCH v3 2/5] tests/migration: Make initrd-stress.img built by default yong.huang
2024-10-22 2:14 ` [PATCH v3 3/5] guestperf: Support deferred migration for multifd yong.huang
2024-10-22 2:14 ` [PATCH v3 4/5] guestperf: Nitpick the inconsistent parameters yong.huang
2024-10-22 2:14 ` [PATCH v3 5/5] guestperf: Introduce multifd compression option yong.huang
2024-10-23 15:05 ` [PATCH v3 0/5] Guestperf: miscellaneous refinement and enrichment Fabiano Rosas
2024-10-24 2:06 ` Yong Huang
2024-10-24 12:28 ` Peter Xu
2024-11-29 10:08 ` Yong Huang
2024-11-29 12:27 ` Fabiano Rosas
2024-11-29 13:44 ` Fabiano Rosas
2024-11-30 14:01 ` Yong Huang
2024-12-02 19:49 ` Peter Xu
2024-12-03 8:10 ` Daniel P. Berrangé
2024-12-03 12:20 ` Fabiano Rosas
2024-12-03 12:30 ` Daniel P. Berrangé
2024-12-03 13:15 ` Fabiano Rosas
2024-12-03 17:40 ` Peter Xu [this message]
2024-12-09 2:50 ` Yong Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z09CdpY4C5Eq6OxI@x1n \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=yong.huang@smartx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).