From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BFDABE77173 for ; Fri, 6 Dec 2024 11:46:46 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tJWn9-0004Dc-SG; Fri, 06 Dec 2024 06:46:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJWmr-0004Cn-On for qemu-devel@nongnu.org; Fri, 06 Dec 2024 06:46:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tJWmn-0008N7-Sc for qemu-devel@nongnu.org; Fri, 06 Dec 2024 06:46:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733485575; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KBwOpemEBqlNmPB2lZ+/51jaUp+413L5fMNmznOJi1A=; b=SQ+U9F0ziYDjWeTDHhVd36IpqUHpOrVoD/rNwIRNU7gYQtrJiCDauM5QAQJDk3Kh0HGVkZ IAgnl8jhGjHtNpkacmuCYM27U9gzE9uurKxleOLhSahFGRBRPw+t5++PFokG6x4sUNsSYb YvM7+xaOCgYAHrA2UqI1wzdB9vGYgI4= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-rpDeA9GNNdS-8Wbm2CdB3g-1; Fri, 06 Dec 2024 06:46:13 -0500 X-MC-Unique: rpDeA9GNNdS-8Wbm2CdB3g-1 X-Mimecast-MFC-AGG-ID: rpDeA9GNNdS-8Wbm2CdB3g Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ADCCE1955F40; Fri, 6 Dec 2024 11:46:10 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.160]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 40495300019E; Fri, 6 Dec 2024 11:46:02 +0000 (UTC) Date: Fri, 6 Dec 2024 11:45:58 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Cc: Pierrick Bouvier , qemu-devel@nongnu.org, Fabiano Rosas , Kevin Wolf , Richard Henderson , Vladimir Sementsov-Ogievskiy , gustavo.romero@linaro.org, Andrew Melnychenko , qemu-arm@nongnu.org, alex.bennee@linaro.org, Konstantin Kostiuk , Eric Blake , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Peter Xu , Markus Armbruster , Yuri Benditovich , Jason Wang , Michael Roth , Paolo Bonzini , Thomas Huth , manos.pitsidianakis@linaro.org, qemu-block@nongnu.org Subject: Re: [PATCH v2 2/6] docs/devel: add git-publish for patch submitting Message-ID: References: <20241205222241.3789437-1-pierrick.bouvier@linaro.org> <20241205222241.3789437-3-pierrick.bouvier@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Dec 06, 2024 at 11:43:11AM +0000, Peter Maydell wrote: > On Fri, 6 Dec 2024 at 11:32, Daniel P. Berrangé wrote: > > > > On Thu, Dec 05, 2024 at 02:22:37PM -0800, Pierrick Bouvier wrote: > > > Signed-off-by: Pierrick Bouvier > > > --- > > > docs/devel/submitting-a-patch.rst | 19 +++++++++++++++++++ > > > 1 file changed, 19 insertions(+) > > > > > > diff --git a/docs/devel/submitting-a-patch.rst b/docs/devel/submitting-a-patch.rst > > > index 03b2ac298aa..f8b7fc59544 100644 > > > --- a/docs/devel/submitting-a-patch.rst > > > +++ b/docs/devel/submitting-a-patch.rst > > > @@ -235,6 +235,25 @@ to another list.) ``git send-email`` (`step-by-step setup guide > > > works best for delivering the patch without mangling it, but > > > attachments can be used as a last resort on a first-time submission. > > > > > > +.. _use_git_publish: > > > + > > > +Use git-publish > > > +~~~~~~~~~~~~~~~ > > > + > > > +If you already configured git send-email, you can simply use `git-publish > > > +`__ to send series. > > > + > > > +:: > > > + > > > + $ git checkout master -b my-feature > > > + $ # work on new commits, add your 'Signed-off-by' lines to each > > > + $ git publish > > > + $ ... more work, rebase on master, ... > > > + $ git publish # will send a v2 > > > + > > > +Each time you post a series, git-publish will create a local tag with the format > > > +``-v`` to record the patch series. > > > > Lets also mention > > > > "When sending patch emails, 'git publish' will consult the output > > of 'scripts/get_maintainers.pl' and automatically CC anyone listed > > as maintainers of the affected code. Generally you should accept the > > suggested CC list, but there may sometimes be scenarios where it is > > appropriate to cut it down (eg on certain large tree-wide cleanups), > > or augment it with other interested people" > > > > Second, lets say something about pull requests > > > > "When a subsystem maintainer is ready to send a pull request, the > > 'git publish --pull' command will triggering GPG tag signing, > > publish the branch to the git remote name specified by the > > 'remote.pushDefault' config option, and send the email series' > > We don't do pull requests for the normal "end developer submits > a patch" process, and given the prevalence of the github/gitlab > "all contributions go in as pull requests" model, I think that > talking about pull requests here (except to say "we don't do them") > would be confusing. If we want to document how you can use git publish > for pull request submission we can do that in > docs/devel/submitting-a-pull-request.rst. Ah yes, I agree with that. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|