From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F2C6E7717D for ; Mon, 9 Dec 2024 11:32:11 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tKbyv-0004zd-I1; Mon, 09 Dec 2024 06:31:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKbyn-0004z9-E2 for qemu-devel@nongnu.org; Mon, 09 Dec 2024 06:31:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tKbyh-0006XW-GT for qemu-devel@nongnu.org; Mon, 09 Dec 2024 06:31:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733743859; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=0vJhcKc7fj9o2wWq9N3FU4eTMtwjH0zgOsUn7WWeM2k=; b=f8/K5wSJM1Mxa+5/uFWCObruWE2wQDDMhceIGQ+PasZWvJFuaIm/jZReS5SYuwkHIxt4Fh zZuTJBqvOezahTI5qVqx8TEqfkqgFg+iq84fX65K7MI5kEQ6NnapcOrse1tUtZ0CsHAlxQ zJVwYyS5K2K9qz5xr1E5OqJ0pJ6eG7E= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-JwHW4dulPJiETGGjRvC19g-1; Mon, 09 Dec 2024 06:30:54 -0500 X-MC-Unique: JwHW4dulPJiETGGjRvC19g-1 X-Mimecast-MFC-AGG-ID: JwHW4dulPJiETGGjRvC19g Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5581719560A3; Mon, 9 Dec 2024 11:30:52 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.115]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1020C195608A; Mon, 9 Dec 2024 11:30:49 +0000 (UTC) Date: Mon, 9 Dec 2024 11:30:46 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Konstantin Kostiuk Cc: qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Michael Roth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH] qga: Add log to guest-fsfreeze-thaw command Message-ID: References: <20241209111817.31307-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241209111817.31307-1-kkostiuk@redhat.com> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.495, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Dec 09, 2024 at 01:18:17PM +0200, Konstantin Kostiuk wrote: > Signed-off-by: Konstantin Kostiuk > --- > qga/commands-posix.c | 3 +++ > qga/commands-win32.c | 2 ++ > 2 files changed, 5 insertions(+) > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index 636307bedf..ac8d150582 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c > @@ -805,6 +805,9 @@ int64_t qmp_guest_fsfreeze_thaw(Error **errp) > int ret; > > ret = qmp_guest_fsfreeze_do_thaw(errp); > + > + slog("guest-fsthaw called"); If ret < 0, then thawing failed and surely it is potentially unsafe to log ? > + > if (ret >= 0) { > ga_unset_frozen(ga_state); > execute_fsfreeze_hook(FSFREEZE_HOOK_THAW, errp); > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index 038beb8cfa..3a6f3ac7c5 100644 > --- a/qga/commands-win32.c > +++ b/qga/commands-win32.c > @@ -1272,6 +1272,8 @@ int64_t qmp_guest_fsfreeze_thaw(Error **errp) > > qga_vss_fsfreeze(&i, false, NULL, errp); > > + slog("guest-fsthaw called"); > + > ga_unset_frozen(ga_state); > return i; > } > -- > 2.47.1 > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|