From: Zhao Liu <zhao1.liu@intel.com>
To: Ani Sinha <anisinha@redhat.com>
Cc: Sergio Lopez <slp@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
Michael Tsirkin <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Igor Mammedov <imammedo@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
Daniel Berrange <berrange@redhat.com>
Subject: Re: [PATCH] hw/i386/cpu: remove default_cpu_version and simplify
Date: Thu, 12 Dec 2024 22:05:39 +0800 [thread overview]
Message-ID: <Z1rts37J6H8f02iT@intel.com> (raw)
In-Reply-To: <891266A0-3863-48FA-9440-64EB9364E665@redhat.com>
> Had a conversation with Igor offline. CPU_VERSION_LATEST does not work since it’s a moving target. Therefore for a specific machine, what version of cpu model will be chosen will depend on what is latest and this will change with time. It can break guests that stick to a single cpu model.
>
> One way to fix this would be to keep a fixed mapping between cpu model and machine versions. However, it will be a nightmare to maintain such mappings.
Thanks Ani!
The commit ad18392 also mentioned the plan to move to CPU_VERSION_LATEST.
Because previsou commits have repeatedly mentioned the plan to move to
CPU_VERSION_LATEST (not only the commit dcafd1ef0af227 you referred, but
also the commit ad18392), I think it's necessary to include the
termination of this plan (i.e., your explanation of why you are no longer
attempting to move to CPU_VERSION_LATEST) in the commit message.
This way, the history regarding default_cpu_version will be easier to
search, and it effectively puts an end to the previous plan.
Thanks,
Zhao
next prev parent reply other threads:[~2024-12-12 13:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-08 6:48 [PATCH] hw/i386/cpu: remove default_cpu_version and simplify Ani Sinha
2024-12-09 15:10 ` Zhao Liu
2024-12-09 15:38 ` Ani Sinha
2024-12-10 14:43 ` Ani Sinha
2024-12-12 14:05 ` Zhao Liu [this message]
2024-12-12 14:50 ` Ani Sinha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1rts37J6H8f02iT@intel.com \
--to=zhao1.liu@intel.com \
--cc=anisinha@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).