From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
Eduardo Habkost <eduardo@habkost.net>,
"Michael S . Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Tao Su <tao1.su@linux.intel.com>,
Xiaoyao Li <xiaoyao.li@intel.com>,
Pankaj Gupta <pankaj.gupta@amd.com>,
Zide Chen <zide.chen@intel.com>,
qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH v5 11/11] target/i386/kvm: Replace ARRAY_SIZE(msr_handlers) with KVM_MSR_FILTER_MAX_RANGES
Date: Wed, 25 Dec 2024 11:16:19 +0800 [thread overview]
Message-ID: <Z2t5AxDxRvQ1sIO8@intel.com> (raw)
In-Reply-To: <5463356b-827f-4c9f-a76e-02cd580fe885@redhat.com>
On Tue, Dec 24, 2024 at 04:54:41PM +0100, Paolo Bonzini wrote:
> Date: Tue, 24 Dec 2024 16:54:41 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: Re: [PATCH v5 11/11] target/i386/kvm: Replace
> ARRAY_SIZE(msr_handlers) with KVM_MSR_FILTER_MAX_RANGES
>
> On 11/6/24 04:07, Zhao Liu wrote:
> > kvm_install_msr_filters() uses KVM_MSR_FILTER_MAX_RANGES as the bound
> > when traversing msr_handlers[], while other places still compute the
> > size by ARRAY_SIZE(msr_handlers).
> >
> > In fact, msr_handlers[] is an array with the fixed size
> > KVM_MSR_FILTER_MAX_RANGES, so there is no difference between the two
> > ways.
> >
> > For the code consistency and to avoid additional computational overhead,
> > use KVM_MSR_FILTER_MAX_RANGES instead of ARRAY_SIZE(msr_handlers).
>
> I agree with the consistency but I'd go the other direction.
>
OK, I'll switch to the other way.
Thanks,
Zhao
next prev parent reply other threads:[~2024-12-25 2:58 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 3:07 [PATCH v5 00/11] i386: miscellaneous cleanup Zhao Liu
2024-11-06 3:07 ` [PATCH v5 01/11 for v9.2?] i386/cpu: Mark avx10_version filtered when prefix is NULL Zhao Liu
2024-11-06 12:22 ` Tao Su
2024-12-20 21:04 ` Michael Tokarev
2025-05-12 9:35 ` Michael Tokarev
2025-05-13 3:39 ` Zhao Liu
2024-11-06 3:07 ` [PATCH v5 02/11] target/i386/kvm: Add feature bit definitions for KVM CPUID Zhao Liu
2024-11-06 3:07 ` [PATCH v5 03/11] target/i386/kvm: Remove local MSR_KVM_WALL_CLOCK and MSR_KVM_SYSTEM_TIME definitions Zhao Liu
2024-11-06 3:07 ` [PATCH v5 04/11] target/i386/kvm: Only save/load kvmclock MSRs when kvmclock enabled Zhao Liu
2024-12-24 15:31 ` Paolo Bonzini
2024-12-25 3:48 ` Zhao Liu
2024-11-06 3:07 ` [PATCH v5 05/11] target/i386/kvm: Save/load MSRs of kvmclock2 (KVM_FEATURE_CLOCKSOURCE2) Zhao Liu
2024-12-24 15:32 ` Paolo Bonzini
2024-12-25 3:49 ` Zhao Liu
2024-11-06 3:07 ` [PATCH v5 06/11] target/i386/kvm: Drop workaround for KVM_X86_DISABLE_EXITS_HTL typo Zhao Liu
2024-11-06 3:07 ` [PATCH v5 07/11] target/i386/confidential-guest: Fix comment of x86_confidential_guest_kvm_type() Zhao Liu
2024-11-06 3:07 ` [PATCH v5 08/11] target/i386/kvm: Clean up return values of MSR filter related functions Zhao Liu
2024-11-06 3:07 ` [PATCH v5 09/11] target/i386/kvm: Return -1 when kvm_msr_energy_thread_init() fails Zhao Liu
2024-11-06 3:07 ` [PATCH v5 10/11] target/i386/kvm: Clean up error handling in kvm_arch_init() Zhao Liu
2024-12-24 15:53 ` Paolo Bonzini
2024-12-25 3:14 ` Zhao Liu
2024-11-06 3:07 ` [PATCH v5 11/11] target/i386/kvm: Replace ARRAY_SIZE(msr_handlers) with KVM_MSR_FILTER_MAX_RANGES Zhao Liu
2024-12-24 15:54 ` Paolo Bonzini
2024-12-25 3:16 ` Zhao Liu [this message]
2024-12-18 16:10 ` [PATCH v5 00/11] i386: miscellaneous cleanup Zhao Liu
2024-12-24 16:01 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2t5AxDxRvQ1sIO8@intel.com \
--to=zhao1.liu@intel.com \
--cc=eduardo@habkost.net \
--cc=kvm@vger.kernel.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pankaj.gupta@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=tao1.su@linux.intel.com \
--cc=xiaoyao.li@intel.com \
--cc=zide.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).