From: Anthony PERARD <anthony@xenproject.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: qemu-devel@nongnu.org, "Roger Pau Monné" <roger.pau@citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Paul Durrant" <paul@xen.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Kevin Wolf" <kwolf@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Jason Wang" <jasowang@redhat.com>,
xen-devel@lists.xenproject.org, qemu-block@nongnu.org
Subject: Re: [PATCH v3 2/7] xen: do not use '%ms' scanf specifier
Date: Wed, 15 Jan 2025 17:45:03 +0100 [thread overview]
Message-ID: <Z4fmD4UZPcSdfEE8@l14> (raw)
In-Reply-To: <20250115163542.291424-3-dwmw2@infradead.org>
On Wed, Jan 15, 2025 at 04:27:20PM +0000, David Woodhouse wrote:
> From: Roger Pau Monne <roger.pau@citrix.com>
>
> The 'm' parameter used to request auto-allocation of the destination variable
> is not supported on FreeBSD, and as such leads to failures to parse.
>
> What's more, the current usage of '%ms' with xs_node_scanf() is pointless, as
> it just leads to a double allocation of the same string. Instead use
> xs_node_read() to read the whole xenstore node.
>
> Fixes: a783f8ad4ec9 ('xen: add a mechanism to automatically create XenDevice-s...')
> Fixes: 9b7737469080 ('hw/xen: update Xen console to XenDevice model')
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>
Thanks,
--
Anthony PERARD
next prev parent reply other threads:[~2025-01-15 16:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 16:27 [PATCH v3 1/7] xen: error handling and FreeBSD compatibility fixes David Woodhouse
2025-01-15 16:27 ` [PATCH v3 1/7] hw/xen: Add xs_node_read() helper function David Woodhouse
2025-01-15 16:44 ` Anthony PERARD
2025-01-15 16:27 ` [PATCH v3 2/7] xen: do not use '%ms' scanf specifier David Woodhouse
2025-01-15 16:45 ` Anthony PERARD [this message]
2025-01-15 16:46 ` Andrew Cooper
2025-01-15 16:27 ` [PATCH v3 3/7] hw/xen: Use xs_node_read() from xs_node_vscanf() David Woodhouse
2025-01-15 16:27 ` [PATCH v3 4/7] hw/xen: Use xs_node_read() from xen_console_get_name() David Woodhouse
2025-01-15 16:27 ` [PATCH v3 5/7] hw/xen: Use xs_node_read() from xen_netdev_get_name() David Woodhouse
2025-01-15 16:27 ` [PATCH v3 6/7] hw/xen: Use xs_node_read() from xenstore_read_str() instead of open-coding it David Woodhouse
2025-01-15 16:27 ` [PATCH v3 7/7] hw/xen: Fix errp handling in xen_console David Woodhouse
2025-01-15 16:49 ` Anthony PERARD
2025-01-15 17:44 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4fmD4UZPcSdfEE8@l14 \
--to=anthony@xenproject.org \
--cc=dwmw2@infradead.org \
--cc=edgar.iglesias@gmail.com \
--cc=hreitz@redhat.com \
--cc=jasowang@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).