qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Prasad Pandit <ppandit@redhat.com>
Cc: qemu-devel@nongnu.org, farosas@suse.de, berrange@redhat.com,
	Prasad Pandit <pjp@fedoraproject.org>
Subject: Re: [PATCH v3 4/4] tests/qtest/migration: add postcopy test with multifd
Date: Fri, 24 Jan 2025 10:38:32 -0500	[thread overview]
Message-ID: <Z5Oz-Kz4rysFQ-n1@x1n> (raw)
In-Reply-To: <CAE8KmOywe888S-oCoO=4=oFsXuN=AfuuqvT27LGor-UTC78YoQ@mail.gmail.com>

On Fri, Jan 24, 2025 at 06:15:20PM +0530, Prasad Pandit wrote:
> Hello Peter,
> 
> On Thu, 23 Jan 2025 at 16:39, Prasad Pandit <ppandit@redhat.com> wrote:
> > On Wed, 22 Jan 2025 at 21:40, Peter Xu <peterx@redhat.com> wrote:
> > > I believe many of the tests can be avoided, but still below is a list of
> > > minimum tests that I think might still be good to add:
> > >         # /x86_64/migration/postcopy/plain
> > >         # /x86_64/migration/postcopy/recovery/tls/psk
> > >         # /x86_64/migration/postcopy/preempt/plain
> > >         # /x86_64/migration/postcopy/preempt/recovery/tls/psk
> ---
> $ ../qtest/migration-test --tap -k -r
> '/x86_64/migration/multifd+postcopy' | grep -i 'slow test'
> # slow test /x86_64/migration/multifd+postcopy/plain executed in 1.28 secs
> # slow test /x86_64/migration/multifd+postcopy/recovery/tls/psk
> executed in 2.43 secs
> # slow test /x86_64/migration/multifd+postcopy/preempt/plain executed
> in 1.52 secs
> # slow test /x86_64/migration/multifd+postcopy/preempt/recovery/tls/psk
> executed in 3.32 secs
> ---
> * Postcopy tests are working well with setting 'multifd = true'.

Great.

> 
> > >         # /x86_64/migration/multifd/tcp/tls/psk/match
> > >         # /x86_64/migration/multifd/tcp/plain/zstd
> > >         # /x86_64/migration/multifd/tcp/plain/cancel
> 
> * Above precopy tests already enable (16) multifd channels and they
> seem to test scenarios like: resume after migrate_cancel() or precopy
> with compression (zstd). Enabling 'postcopy' here is not the same as
> setting 'postcopy=true'. Do we really need to redefine these tests for
> postcopy migration? Does compression (zstd/zlib etc.) OR
> migrate_cancle() work with 'postcopy' migration?

Since multifd doesn't work with postcopy phase, compression so far cannot
happen in postcopy phase but only in precopy phase.

So the tests I suggested was trying to make sure multifd major features (in
this case, tls, compression, and cancellation) work like before even if we
set postcopy-ram=on in the feature list, because after your changes merged,
people may start always set postcopy-ram=on for all cases.

OTOH, these test cases do not test anything that would happen in postcopy
phase, they should be covered by the postcopy tests you added above.

Thanks,

-- 
Peter Xu



  reply	other threads:[~2025-01-24 15:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 13:10 [PATCH v3 0/4] Allow to enable multifd and postcopy migration together Prasad Pandit
2025-01-21 13:10 ` [PATCH v3 1/4] migration/multifd: move macros to multifd header Prasad Pandit
2025-01-21 13:10 ` [PATCH v3 2/4] migration: refactor ram_save_target_page functions Prasad Pandit
2025-01-21 13:10 ` [PATCH v3 3/4] migration: enable multifd and postcopy together Prasad Pandit
2025-01-21 13:10 ` [PATCH v3 4/4] tests/qtest/migration: add postcopy test with multifd Prasad Pandit
2025-01-21 15:47   ` Peter Xu
2025-01-22  7:56     ` Prasad Pandit
2025-01-22 16:10       ` Peter Xu
2025-01-23 11:09         ` Prasad Pandit
2025-01-24 12:45           ` Prasad Pandit
2025-01-24 15:38             ` Peter Xu [this message]
2025-01-25 12:15               ` Prasad Pandit
2025-01-21 15:50 ` [PATCH v3 0/4] Allow to enable multifd and postcopy migration together Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z5Oz-Kz4rysFQ-n1@x1n \
    --to=peterx@redhat.com \
    --cc=berrange@redhat.com \
    --cc=farosas@suse.de \
    --cc=pjp@fedoraproject.org \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).