From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 0/2] migration: Reduce migration-test time for non-KVM archs
Date: Thu, 30 Jan 2025 16:16:13 -0500 [thread overview]
Message-ID: <Z5vsHZZIut6T5KqQ@x1.local> (raw)
In-Reply-To: <20250130184012.5711-1-farosas@suse.de>
On Thu, Jan 30, 2025 at 03:40:10PM -0300, Fabiano Rosas wrote:
> Hi, continuing the work from the previous[1] series to reduce the time
> migration-test takes during make check, here's a couple of patches to
> create a smaller set of tests.
>
> The change is that from now on, ./migration-test will only run a
> limited set of tests (~12), while the full set (64) requires that the
> --full flag is passed on. Only those calling the test manually need to
> care about this new flag.
>
> For everyone else, qtest/meson.build will automatically add --full in
> case KVM is available for the target architecture. All other
> architectures run the small set.
>
> The choice of tests for the small set has been arbitrarily made in
> patch 2. I expect that once we close in on a list of tests, new tests
> will only be added under the --full flag and the small set will be
> kept stable.
>
> An unwritten but maybe obvious rule is that slow or flaky tests should
> not be added to the small set and once detected should be moved to the
> full set.
>
> More details in patch 1.
Looks all good here, thanks!
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2025-01-30 21:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-30 18:40 [PATCH 0/2] migration: Reduce migration-test time for non-KVM archs Fabiano Rosas
2025-01-30 18:40 ` [PATCH 1/2] tests/qtest/migration: Add --full option Fabiano Rosas
2025-01-30 18:40 ` [PATCH 2/2] tests/qtest/migration: Pick smoke tests Fabiano Rosas
2025-01-30 21:16 ` Peter Xu [this message]
2025-02-03 14:08 ` [PATCH 0/2] migration: Reduce migration-test time for non-KVM archs Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5vsHZZIut6T5KqQ@x1.local \
--to=peterx@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=farosas@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).