qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org
Subject: Re: [PATCH 1/2] rust: remove unnecessary Cargo.toml metadata
Date: Thu, 6 Feb 2025 18:42:14 +0800	[thread overview]
Message-ID: <Z6SSBl3j9DUgdwLi@intel.com> (raw)
In-Reply-To: <20250129083705.1321407-2-pbonzini@redhat.com>

On Wed, Jan 29, 2025 at 09:37:03AM +0100, Paolo Bonzini wrote:
> Date: Wed, 29 Jan 2025 09:37:03 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 1/2] rust: remove unnecessary Cargo.toml metadata
> X-Mailer: git-send-email 2.48.1
> 
> Some items of Cargo.toml (readme, homepage, repository) are
> only present because of clippy::cargo warnings being enabled in
> rust/hw/char/pl011/src/lib.rs.  But these items are not
> particularly useful and would be all the same for all Cargo.toml
> files in the QEMU workspace.  Clean them up.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  rust/hw/char/pl011/Cargo.toml   |  3 ---
>  rust/hw/char/pl011/README.md    | 31 -------------------------------
>  rust/hw/char/pl011/src/lib.rs   | 14 ++++++--------
>  rust/qemu-api-macros/Cargo.toml |  3 ---
>  rust/qemu-api-macros/README.md  |  1 -
>  5 files changed, 6 insertions(+), 46 deletions(-)
>  delete mode 100644 rust/hw/char/pl011/README.md
>  delete mode 100644 rust/qemu-api-macros/README.md
>

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>



  reply	other threads:[~2025-02-06 10:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-29  8:37 [PATCH 0/2] rust: small cleanups to Cargo.toml files Paolo Bonzini
2025-01-29  8:37 ` [PATCH 1/2] rust: remove unnecessary Cargo.toml metadata Paolo Bonzini
2025-02-06 10:42   ` Zhao Liu [this message]
2025-01-29  8:37 ` [PATCH 2/2] rust: include rust_version in Cargo.toml Paolo Bonzini
2025-02-06 11:02   ` Zhao Liu
2025-02-06 22:31     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z6SSBl3j9DUgdwLi@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-rust@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).