From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20EFDC02194 for ; Fri, 7 Feb 2025 14:39:38 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tgPVv-0003Wy-9L; Fri, 07 Feb 2025 09:39:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgPVr-0003V3-JV for qemu-devel@nongnu.org; Fri, 07 Feb 2025 09:39:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tgPVp-0004Hf-HF for qemu-devel@nongnu.org; Fri, 07 Feb 2025 09:39:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738939159; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q73uFWRxOCH7wAULzOtGo/V/4YJ2rPn1SdfZJ+Uh/Uw=; b=V0TToJ9gb8xw1tM7d/pwzugvKpq51h1hLBtatLtglKT9hJiiEsXOwAs+KsJDL7Uq117vbp SX7r3ZU9Gi8yHLPgvFYLXWYve2ryuiw8hGV7DK+OXRX+21p5EbhE6/u3361Wj/dxq6YMFI RE/7VLTX5OFnRi1CIDqMDzxDIH4xiv0= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-4poWYhdLOMSmI5jCW8f7Ig-1; Fri, 07 Feb 2025 09:39:12 -0500 X-MC-Unique: 4poWYhdLOMSmI5jCW8f7Ig-1 X-Mimecast-MFC-AGG-ID: 4poWYhdLOMSmI5jCW8f7Ig Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0E0291956089; Fri, 7 Feb 2025 14:39:11 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.56]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 001081800874; Fri, 7 Feb 2025 14:39:08 +0000 (UTC) Date: Fri, 7 Feb 2025 14:39:05 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Fabiano Rosas Cc: qemu-devel@nongnu.org, Peter Xu , "Maciej S . Szmigiero" Subject: Re: [RFC PATCH v2 2/8] io: tls: Add qio_channel_tls_bye Message-ID: References: <20250207142758.6936-1-farosas@suse.de> <20250207142758.6936-3-farosas@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250207142758.6936-3-farosas@suse.de> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Feb 07, 2025 at 11:27:52AM -0300, Fabiano Rosas wrote: > Add a task dispatcher for gnutls_bye similar to the > qio_channel_tls_handshake_task(). The gnutls_bye() call might be > interrupted and so it needs to be rescheduled. > > The migration code will make use of this to help the migration > destination identify a premature EOF. Once the session termination is > in place, any EOF that happens before the source issued gnutls_bye() > will be considered an error. > > Signed-off-by: Fabiano Rosas > --- > include/io/channel-tls.h | 12 ++++++ > io/channel-tls.c | 84 ++++++++++++++++++++++++++++++++++++++++ > io/trace-events | 5 +++ > 3 files changed, 101 insertions(+) Reviewed-by: Daniel P. Berrangé Acked-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|