qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Li Zhijian <lizhijian@fujitsu.com>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
	Laurent Vivier <lvivier@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v4 2/6] migration: check RDMA and capabilities are compatible on both sides
Date: Wed, 26 Feb 2025 10:46:48 -0500	[thread overview]
Message-ID: <Z783aPBdOKGB7Bgj@x1.local> (raw)
In-Reply-To: <20250226063043.732455-3-lizhijian@fujitsu.com>

On Wed, Feb 26, 2025 at 02:30:39PM +0800, Li Zhijian wrote:
> Depending on the order of starting RDMA and setting capability,
> the following scenarios can be categorized into the following scenarios:
> Source:
>  S1: [set capabilities] -> [Start RDMA outgoing]
> Destination:
>  D1: [set capabilities] -> [Start RDMA incoming]
>  D2: [Start RDMA incoming] -> [set capabilities]
> 
> Previously, compatibility between RDMA and capabilities was verified only
> in scenario D1, potentially causing migration failures in other situations.
> 
> For scenarios S1 and D1, we can seamlessly incorporate
> migration_transport_compatible() to address compatibility between
> channels and capabilities vs transport.
> 
> For scenario D2, ensure compatibility within migrate_caps_check().
> 
> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu



  reply	other threads:[~2025-02-26 15:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-26  6:30 [PATCH v4 0/6] migration/rdma: fixes, refactor and cleanup Li Zhijian via
2025-02-26  6:30 ` [PATCH v4 1/6] migration: Prioritize RDMA in ram_save_target_page() Li Zhijian via
2025-02-26  6:30 ` [PATCH v4 2/6] migration: check RDMA and capabilities are compatible on both sides Li Zhijian via
2025-02-26 15:46   ` Peter Xu [this message]
2025-02-26  6:30 ` [PATCH v4 3/6] migration: disable RDMA + postcopy-ram Li Zhijian via
2025-02-26  6:30 ` [PATCH v4 4/6] migration/rdma: Remove redundant migration_in_postcopy checks Li Zhijian via
2025-02-26 15:49   ` Peter Xu
2025-02-26  6:30 ` [PATCH v4 5/6] migration: Unfold control_save_page() Li Zhijian via
2025-02-26 15:51   ` Peter Xu
2025-02-27  0:42     ` Zhijian Li (Fujitsu) via
2025-02-27 16:43       ` Peter Xu
2025-02-26  6:30 ` [PATCH v4 6/6] migration: Add qtest for migration over RDMA Li Zhijian via
2025-02-28 13:49   ` Fabiano Rosas
2025-03-03  2:10     ` Zhijian Li (Fujitsu) via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z783aPBdOKGB7Bgj@x1.local \
    --to=peterx@redhat.com \
    --cc=farosas@suse.de \
    --cc=lizhijian@fujitsu.com \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).