From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 120F7C021A9 for ; Mon, 17 Feb 2025 12:20:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tk06c-0004TE-Fv; Mon, 17 Feb 2025 07:20:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tk06Z-0004Qg-6q for qemu-devel@nongnu.org; Mon, 17 Feb 2025 07:20:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tk06V-0005h9-Si for qemu-devel@nongnu.org; Mon, 17 Feb 2025 07:20:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739794800; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iSaWcD6nXHgZSgsDcbQ6zNnuzAF+yq0h6VV2aXGveKo=; b=hkCjE+HgZXxQqoAs69cq7+e7Z6rJjOdG3DkRbXQL5pwtQEOT3rxj7WXV93N7AHpxeSQNrg xCg1IgyNmDSCEy7jBtCTKf7lwa/Ou2dwSSlTVLf9WPXC0lvQJzNlEp+Dc060V1IkeAMW9Y 7IRv8QquKywwV/lnvmqK3f4bnIJ3K7M= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-ZbXHzPS1Oo6c9DyMLrONNg-1; Mon, 17 Feb 2025 07:19:57 -0500 X-MC-Unique: ZbXHzPS1Oo6c9DyMLrONNg-1 X-Mimecast-MFC-AGG-ID: ZbXHzPS1Oo6c9DyMLrONNg_1739794796 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 58B8219039C1; Mon, 17 Feb 2025 12:19:56 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.176]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C3AC419560A3; Mon, 17 Feb 2025 12:19:54 +0000 (UTC) Date: Mon, 17 Feb 2025 12:19:51 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Xiaoyao Li , qemu-stable@nongnu.org Subject: Re: [PATCH] physmem: replace assertion with error Message-ID: References: <20250217120812.396522-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250217120812.396522-1-pbonzini@redhat.com> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Feb 17, 2025 at 01:08:12PM +0100, Paolo Bonzini wrote: > It is possible to start QEMU with a confidential-guest-support object > even in TCG mode. While there is already a check in qemu_machine_creation_done: > > if (machine->cgs && !machine->cgs->ready) { > error_setg(errp, "accelerator does not support confidential guest %s", > object_get_typename(OBJECT(machine->cgs))); > exit(1); > } > > the creation of RAMBlocks happens earlier, in qemu_init_board(), if > the command line does not override the default memory backend with > -M memdev. Then the RAMBlock will try to use guest_memfd (because > machine_require_guest_memfd correctly returns true; at least correctly > according to the current implementation) and trigger the assertion > failure for kvm_enabled(). This happend with a command line as > simple as the following: > > qemu-system-x86_64 -m 512 -nographic -object sev-snp-guest,reduced-phys-bits=48,id=sev0 \ > -M q35,kernel-irqchip=split,confidential-guest-support=sev0 > qemu-system-x86_64: ../system/physmem.c:1871: ram_block_add: Assertion `kvm_enabled()' failed. > > Cc: Xiaoyao Li > Cc: qemu-stable@nongnu.org > Signed-off-by: Paolo Bonzini > --- > system/physmem.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|