* [PATCH] i386: Fix the missing Rust HPET configuration option
@ 2025-02-17 15:44 Zhao Liu
2025-02-18 8:09 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Zhao Liu @ 2025-02-17 15:44 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, qemu-rust, Zhao Liu
The configuration option of Rust HPET is missing, so that PC machine
can't boot with "hpet=on" when QEMU Rust support is enabled.
Add the Rust HPET configuration option.
Fixes: d128c341a744 ("i386: enable rust hpet for pc when rust is enabled")
Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
---
hw/timer/Kconfig | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig
index 9ac008453408..c051597180f4 100644
--- a/hw/timer/Kconfig
+++ b/hw/timer/Kconfig
@@ -13,6 +13,10 @@ config HPET
bool
default y if PC && !HAVE_RUST
+config X_HPET_RUST
+ bool
+ default y if PC && HAVE_RUST
+
config I8254
bool
depends on ISA_BUS
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i386: Fix the missing Rust HPET configuration option
2025-02-17 15:44 [PATCH] i386: Fix the missing Rust HPET configuration option Zhao Liu
@ 2025-02-18 8:09 ` Paolo Bonzini
2025-02-18 8:40 ` Zhao Liu
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2025-02-18 8:09 UTC (permalink / raw)
To: Zhao Liu; +Cc: qemu-devel, qemu-rust
On 2/17/25 16:44, Zhao Liu wrote:
> The configuration option of Rust HPET is missing, so that PC machine
> can't boot with "hpet=on" when QEMU Rust support is enabled.
>
> Add the Rust HPET configuration option.
>
> Fixes: d128c341a744 ("i386: enable rust hpet for pc when rust is enabled")
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> hw/timer/Kconfig | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/hw/timer/Kconfig b/hw/timer/Kconfig
> index 9ac008453408..c051597180f4 100644
> --- a/hw/timer/Kconfig
> +++ b/hw/timer/Kconfig
> @@ -13,6 +13,10 @@ config HPET
> bool
> default y if PC && !HAVE_RUST
>
> +config X_HPET_RUST
> + bool
> + default y if PC && HAVE_RUST
> +
> config I8254
> bool
> depends on ISA_BUS
The config item is already declared in rust/hw/timer/Kconfig, so it's
enough to do
diff --git b/rust/hw/timer/Kconfig a/rust/hw/timer/Kconfig
index afd98033503..42e421317a5 100644
--- b/rust/hw/timer/Kconfig
+++ a/rust/hw/timer/Kconfig
@@ -1,2 +1,3 @@
config X_HPET_RUST
bool
+ default y if PC && HAVE_RUST
I applied it with your commit message.
Paolo
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i386: Fix the missing Rust HPET configuration option
2025-02-18 8:09 ` Paolo Bonzini
@ 2025-02-18 8:40 ` Zhao Liu
0 siblings, 0 replies; 3+ messages in thread
From: Zhao Liu @ 2025-02-18 8:40 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel, qemu-rust
> The config item is already declared in rust/hw/timer/Kconfig, so it's enough
> to do
>
> diff --git b/rust/hw/timer/Kconfig a/rust/hw/timer/Kconfig
> index afd98033503..42e421317a5 100644
> --- b/rust/hw/timer/Kconfig
> +++ a/rust/hw/timer/Kconfig
> @@ -1,2 +1,3 @@
> config X_HPET_RUST
> bool
> + default y if PC && HAVE_RUST
>
> I applied it with your commit message.
>
Ah, thanks! I misunderstood your comment before...
Regards,
Zhao
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-18 8:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-17 15:44 [PATCH] i386: Fix the missing Rust HPET configuration option Zhao Liu
2025-02-18 8:09 ` Paolo Bonzini
2025-02-18 8:40 ` Zhao Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).