From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAAA5C021B1 for ; Thu, 20 Feb 2025 14:59:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tl80O-0005gx-CJ; Thu, 20 Feb 2025 09:58:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tl80M-0005gU-Sl for qemu-devel@nongnu.org; Thu, 20 Feb 2025 09:58:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tl80L-0004Nn-45 for qemu-devel@nongnu.org; Thu, 20 Feb 2025 09:58:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1740063499; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OAR7SM7CRIDmgmkKisEjno8be/T1UYR8J4bbQaCfP8M=; b=cMn17ZoKKyTi9u9M8/pepgGIldcP4peBUQczySeO/qlRKPmy6upO34Caig4QsJ0QeBIOWG uEAFETSUlc3PFRTmoTxWcDE5njavN4ZxklvJYSsEIVU8xMKb6glgXwoqZ/PP+jiwymZ9oH Vz2h7/ut2ntI7SVZwnQPqGTiDfqo9iU= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-aBK6toz7MqG-P546AcaBmw-1; Thu, 20 Feb 2025 09:58:16 -0500 X-MC-Unique: aBK6toz7MqG-P546AcaBmw-1 X-Mimecast-MFC-AGG-ID: aBK6toz7MqG-P546AcaBmw_1740063495 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 51E281800268; Thu, 20 Feb 2025 14:58:15 +0000 (UTC) Received: from redhat.com (unknown [10.44.34.34]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4BC6219412A3; Thu, 20 Feb 2025 14:58:12 +0000 (UTC) Date: Thu, 20 Feb 2025 15:58:09 +0100 From: Kevin Wolf To: Zhao Liu Cc: qemu-block@nongnu.org, hreitz@redhat.com, pbonzini@redhat.com, manos.pitsidianakis@linaro.org, philmd@linaro.org, qemu-devel@nongnu.org, qemu-rust@nongnu.org Subject: Re: [PATCH v2 04/11] rust/qemu-api: Add wrappers to run futures in QEMU Message-ID: References: <20250218182019.111467-1-kwolf@redhat.com> <20250218182019.111467-5-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.457, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 20.02.2025 um 07:35 hat Zhao Liu geschrieben: > > +/// Use QEMU's event loops to run a Rust [`Future`] to completion and return its result. > > +/// > > +/// This function must be called in coroutine context. If the future isn't ready yet, it yields. > > +pub fn qemu_co_run_future(future: F) -> F::Output { > > + let waker = Waker::from(Arc::new(RunFutureWaker { > > + co: unsafe { bindings::qemu_coroutine_self() }, > > + })); > > + let mut cx = Context::from_waker(&waker); > > + > > + let mut pinned_future = std::pin::pin!(future); > > pin macro stabilized in v1.68.0, but currently the minimum rustc > supported by QEMU is v1.63. Can we check this automatically somehow? I actually seem to remember that I got errors for too new things before. Is the problem here that it's a macro? > I found there's a workaround [*], so we can add a temporary pin.rs in > qemu_api until QEMU bumps up rustc to >= v1.68? > > [*]: https://github.com/rust-lang/rust/issues/93178#issuecomment-1386177439 I don't think we'll need this anywhere else, so I can just open-code what the macro does: // TODO Use std::pin::pin! when MSRV is updated to at least 1.68.0 // SAFETY: `future` is not used any more after this and dropped at the end of the function. let mut pinned_future = unsafe { std::pin::Pin::new_unchecked(&mut future)}; Kevin