Re: [PATCH v3 15/16] iotests: Add qsd-migrate case

[Kevin Wolf <kwolf@redhat.com>]

Am 24.02.2025 um 11:23 hat Thomas Huth geschrieben:
> On 04/02/2025 22.14, Kevin Wolf wrote:
> > Test that it's possible to migrate a VM that uses an image on shared
> > storage through qemu-storage-daemon.
> > 
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> > Acked-by: Fabiano Rosas <farosas@suse.de>
> > Reviewed-by: Eric Blake <eblake@redhat.com>
> > ---
> >   tests/qemu-iotests/tests/qsd-migrate     | 140 +++++++++++++++++++++++
> >   tests/qemu-iotests/tests/qsd-migrate.out |  59 ++++++++++
> >   2 files changed, 199 insertions(+)
> >   create mode 100755 tests/qemu-iotests/tests/qsd-migrate
> >   create mode 100644 tests/qemu-iotests/tests/qsd-migrate.out
> 
>  Hi Kevin,
> 
> this test is failing for me in vmdk mode (discovered with "make check
> SPEED=thorough"):
> 
> $ ./check -vmdk qsd-migrate
> [...]
> qsd-migrate   fail       [11:20:25] [11:20:25]   0.5s                 output
> mismatch (see /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch/vmdk-file-qsd-migrate/qsd-migrate.out.bad)
> --- /home/thuth/devel/qemu/tests/qemu-iotests/tests/qsd-migrate.out
> +++ /home/thuth/tmp/qemu-build/tests/qemu-iotests/scratch/vmdk-file-qsd-migrate/qsd-migrate.out.bad
> @@ -51,6 +51,7 @@
>  --- vm_dst log ---
>  read 4096/4096 bytes at offset 0
>  4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +Pattern verification failed at offset 0, 4096 bytes
>  read 4096/4096 bytes at offset 0
>  4 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>  wrote 4096/4096 bytes at offset 0
> Failures: qsd-migrate
> Failed 1 of 1 iotests
> 
> Is that working for you?

No, and it can't work currently. vmdk and some other formats don't
support migration. If the image were attached directly to QEMU, the
migration block would take effect and make the migration fail.

So we should probably just change supported_fmts in the test case from
'generic' to a list of actually supported image formats. Without
checking, I'm not sure what can be enabled, but at least raw, qcow2 and
qed work.

The other option would be implementing .bdrv_co_invalidate_cache for the
currently unsupported image formats so that they actually can support
migration.

Kevin