From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, michael.roth@amd.com, jsnow@redhat.com
Subject: Re: [PATCH 2/3] qapi: Eliminate OrderedDict
Date: Thu, 27 Feb 2025 09:07:29 +0000 [thread overview]
Message-ID: <Z8ArURisT4bvkVpF@redhat.com> (raw)
In-Reply-To: <20250227080757.3978333-3-armbru@redhat.com>
On Thu, Feb 27, 2025 at 09:07:56AM +0100, Markus Armbruster wrote:
> We use OrderedDict to ensure dictionary order is insertion order.
> Plain dict does that since Python 3.6, but it wasn't guaranteed until
> 3.7. Since we have 3.7 now, replace OrderedDict by dict.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> scripts/qapi/parser.py | 5 ++---
> scripts/qapi/schema.py | 11 +++++------
> tests/qapi-schema/test-qapi.py | 11 +----------
> 3 files changed, 8 insertions(+), 19 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-02-27 9:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 8:07 [PATCH 0/3] qapi: Clean up for Python 3.8 Markus Armbruster
2025-02-27 8:07 ` [PATCH 1/3] docs/about/build-platforms: Correct minimum supported Python version Markus Armbruster
2025-02-27 9:04 ` Daniel P. Berrangé
2025-02-27 8:07 ` [PATCH 2/3] qapi: Eliminate OrderedDict Markus Armbruster
2025-02-27 9:07 ` Daniel P. Berrangé [this message]
2025-02-27 8:07 ` [PATCH 3/3] qapi/introspect: Use @dataclass to simplify Markus Armbruster
2025-02-27 9:09 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8ArURisT4bvkVpF@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).