From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59A1AC282C1 for ; Fri, 28 Feb 2025 15:47:54 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1to2aV-0000z9-Ev; Fri, 28 Feb 2025 10:47:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1to2a9-0000la-Iv; Fri, 28 Feb 2025 10:47:28 -0500 Received: from mail.xenproject.org ([104.130.215.37]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1to2a6-0005aE-7e; Fri, 28 Feb 2025 10:47:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=wYrYPIeLMpXibk0d35LLmBJZ9i6aCN3miwYcK3/IlPk=; b=dV4NVDp+BT30jXxAqv8PE12Hw3 4q30SXCAvJlWfLG5FwqTPZD+ut0UBkuBbi0qq9zgca+jNk4ME9NiMYfyvyUBid4wsDJ5BrtVszYny cqr8t77TP9CFQBC5jCs1l5gHFwumXqziRW/NU7d+U2hYG2diiZuYr0LlUE+rXr1//zLA=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1to2Zp-00AMHm-1O; Fri, 28 Feb 2025 15:47:01 +0000 Received: from [2a01:e0a:1da:8420:b77:bd5:6e45:7633] (helo=l14) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1to2Zo-00FN1V-2C; Fri, 28 Feb 2025 15:47:00 +0000 Date: Fri, 28 Feb 2025 16:46:57 +0100 From: Anthony PERARD To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Richard Henderson , xen-devel@lists.xenproject.org, qemu-arm@nongnu.org, Stefano Stabellini , Paul Durrant , Andrew Cooper , Juergen Gross , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Paolo Bonzini , "Edgar E. Iglesias" , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Peter Maydell , Eduardo Habkost , "Michael S. Tsirkin" , David Woodhouse , Vikram Garhwal , Thomas Huth , Jan Beulich , Marcel Apfelbaum Subject: Re: [PATCH 5/8] hw/xen/xen-hvm: Reduce included headers Message-ID: References: <20250218162618.46167-1-philmd@linaro.org> <20250218162618.46167-6-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250218162618.46167-6-philmd@linaro.org> Received-SPF: pass client-ip=104.130.215.37; envelope-from=anthony@xenproject.org; helo=mail.xenproject.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Feb 18, 2025 at 05:26:15PM +0100, Philippe Mathieu-Daudé wrote: > Have "hw/xen/xen-hvm-common.h" include the bare minimal set > of headers. Adapt sources to avoid errors when refactoring > unrelated headers such: > > include/hw/xen/xen-hvm-common.h:71:5: error: unknown type name ‘xenevtchn_handle’ > 71 | xenevtchn_handle *xce_handle; > | ^~~~~~~~~~~~~~~~ > hw/xen/xen-hvm-common.c: In function ‘cpu_get_ioreq’: > hw/xen/xen-hvm-common.c:227:13: error: implicit declaration of function ‘hw_error’ > 227 | hw_error("Fatal error while trying to get io event!\n"); > | ^~~~~~~~ > | herror > hw/xen/xen-hvm-common.c: In function ‘handle_ioreq’: > hw/xen/xen-hvm-common.c:446:34: error: ‘target_ulong’ undeclared (first use in this function) > 446 | (req->size < sizeof (target_ulong))) { > | ^~~~~~~~~~~~ > hw/i386/xen/xen-hvm.c: In function ‘xen_add_to_physmap’: > hw/i386/xen/xen-hvm.c:298:22: error: implicit declaration of function ‘xen_replace_cache_entry’ > 298 | uint8_t *p = xen_replace_cache_entry(phys_offset, start_addr, size); > | ^~~~~~~~~~~~~~~~~~~~~~~ > hw/i386/xen/xen-hvm.c: In function ‘xen_log_global_start’: > hw/i386/xen/xen-hvm.c:465:9: error: implicit declaration of function ‘xen_enabled’ > 465 | if (xen_enabled()) { > | ^~~~~~~~~~~ > hw/i386/xen/xen-hvm.c: In function ‘regs_to_cpu’: > hw/i386/xen/xen-hvm.c:487:5: error: unknown type name ‘X86CPU’ > 487 | X86CPU *cpu; > | ^~~~~~ > hw/i386/xen/xen-hvm.c:492:15: error: ‘R_EAX’ undeclared (first use in this function) > 492 | env->regs[R_EAX] = req->data; > | ^~~~~ > | REG_RAX > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD