From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DC94C282DE for ; Wed, 5 Mar 2025 16:08:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tprHM-0001Xs-8j; Wed, 05 Mar 2025 11:07:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tprHI-0001XP-Ro for qemu-devel@nongnu.org; Wed, 05 Mar 2025 11:07:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tprHG-0006j3-Iq for qemu-devel@nongnu.org; Wed, 05 Mar 2025 11:07:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741190841; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=0FbufB9azIj51ks58PPvu5Y2aqeLF5m4KfJ2DemOhtw=; b=d+aRBeL9tz7SBAdxCaq/2uysRgnryjzEJDz9sLDcm7EK7VR90qvqkWw2GHwYwx+rOAWFQe ufxFdCcdJmrCrdUMYgxdJIY7Ph/J4x8Oh4rHoVgm2lmIOB3NaS09cfBFIG5ONf1ghPfgjQ t4tUdUpHQw+tQLnEnRvh7YVO+xM1Vc0= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-zsmZfW64OAiS-gXm5gVwpA-1; Wed, 05 Mar 2025 11:07:16 -0500 X-MC-Unique: zsmZfW64OAiS-gXm5gVwpA-1 X-Mimecast-MFC-AGG-ID: zsmZfW64OAiS-gXm5gVwpA_1741190832 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8DF70186653C; Wed, 5 Mar 2025 16:06:34 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.44]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E759F1800255; Wed, 5 Mar 2025 16:06:31 +0000 (UTC) Date: Wed, 5 Mar 2025 16:06:28 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Shalini Chellathurai Saroja Cc: qemu-s390x mailing list , Thomas Huth , qemu-devel mailing list , Nina Schoetterl-Glausch , Hendrik Brueckner Subject: Re: [PATCH qemu v2 1/3] hw/s390x: add CPI identifiers to QOM Message-ID: References: <20250224120449.1764114-1-shalini@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250224120449.1764114-1-shalini@linux.ibm.com> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Feb 24, 2025 at 01:04:47PM +0100, Shalini Chellathurai Saroja wrote: > Add Control-Program Identification (CPI) to the QEMU Object > Model (QOM). The CPI identifiers provide information about > the guest operating system. The CPI identifiers are: > system type, system name, system level and sysplex name. > > The system type provides the OS type of the guest (e.g. LINUX). > The system name provides the name of the guest (e.g. TESTVM). > The system level provides the distribution and kernel version > of the guest OS (e.g. 0x50e00). > The sysplex name provides the sysplex name of the guest > (e.g. SYSPLEX). > > Signed-off-by: Shalini Chellathurai Saroja > --- > hw/s390x/s390-virtio-ccw.c | 29 +++++++++++++++++++++++++++++ > include/hw/s390x/s390-virtio-ccw.h | 8 ++++++++ > qapi/machine.json | 24 ++++++++++++++++++++++++ > 3 files changed, 61 insertions(+) > > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c > index 51ae0c133d..13ea8db1b0 100644 > --- a/hw/s390x/s390-virtio-ccw.c > +++ b/hw/s390x/s390-virtio-ccw.c > @@ -50,6 +50,7 @@ > #include "hw/s390x/virtio-ccw-md.h" > #include "system/replay.h" > #include CONFIG_DEVICES > +#include "qapi/qapi-visit-machine.h" > > static Error *pv_mig_blocker; > > @@ -803,6 +804,26 @@ static void machine_set_loadparm(Object *obj, Visitor *v, > s390_ipl_fmt_loadparm(ms->loadparm, val, errp); > } > > +static void machine_get_control_program_id(Object *obj, Visitor *v, > + const char *name, void *opaque, > + Error **errp) > +{ > + S390CcwMachineState *ms = S390_CCW_MACHINE(obj); > + S390ControlProgramId *cpi; > + cpi = &(S390ControlProgramId){ > + .system_type = g_strndup((char *) ms->cpi.system_type, > + sizeof(ms->cpi.system_type)), > + .system_name = g_strndup((char *) ms->cpi.system_name, > + sizeof(ms->cpi.system_name)), > + .system_level = g_strdup_printf("0x%lx", ms->cpi.system_level), If the data is an integer, we must return it in QMP as an integer, not formatted into a hex string. > + .sysplex_name = g_strndup((char *) ms->cpi.sysplex_name, > + sizeof(ms->cpi.sysplex_name)), > + .timestamp = ms->cpi.timestamp > + }; > +## > +# @S390ControlProgramId: > +# > +# Control-program identifiers provide data about Linux instance. > +# > +# @system-type: operating system of Linux instance Is there a list of well known operating system names, or is this arbitrary free-form text. Needs to be documented. > +# @system-name: system name of Linux instance What is a system name ? Is that a hostname, or is that something else ? > +# > +# @system-level: distribution and kernel version of Linux instance What does this actually mean ? This is a single field, but the docs are describing 2 distinct versions. Even a single version usually has multiple digits and even a string suffix. This needs to document how the version information actually encoded in practice, and if some info is discarded in this process. > +# > +# @sysplex-name: sysplex name of Linux instance I guess "sysplex" is some term people from s390 world would already understand ? It is possible to explain it or do we just have to assume prior knowledge ? > +# > +# @timestamp: latest update of CPI data In what units and epoch ? Seconds since the UNIX epoch, or something else ? > +# > +# Since: 9.2 > +## > +{ 'struct': 'S390ControlProgramId', 'data': { > + 'system-type': 'str', > + 'system-name': 'str', > + 'system-level': 'str', > + 'sysplex-name': 'str', > + 'timestamp': 'uint64' } } > -- > 2.47.0 > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|