qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v2] meson.build: default to -gsplit-dwarf for debug info
Date: Thu, 6 Mar 2025 10:57:10 +0000	[thread overview]
Message-ID: <Z8l_hn0TYozBtn--@redhat.com> (raw)
In-Reply-To: <20250306105306.2064458-1-alex.bennee@linaro.org>

On Thu, Mar 06, 2025 at 10:53:06AM +0000, Alex Bennée wrote:
> This option is supported by both gcc (since 4.7) and clang (since
> 7.0). Not only does this make the linkers job easier by reducing the
> amount of ELF it needs to parse it also reduces the total build size
> quite considerably. In my case a default build went from 5.8G to 3.9G.
> 
> The --disable-split-debug option allows distros to keep all the info
> together for ease of packaging.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> 
> ---
> v1
>   - add --disable/enable-split-debug
>   - move to option_cflags
> v2
>   - removed unneeded []'s
>   - fix stray whitespace
> ---
>  meson.build                   | 5 ++++-
>  meson_options.txt             | 2 ++
>  scripts/meson-buildoptions.sh | 2 ++
>  3 files changed, 8 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2025-03-06 10:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-06 10:53 [PATCH v2] meson.build: default to -gsplit-dwarf for debug info Alex Bennée
2025-03-06 10:57 ` Daniel P. Berrangé [this message]
2025-03-06 11:36 ` Paolo Bonzini
2025-03-06 12:20   ` Alex Bennée
2025-03-06 13:38     ` Paolo Bonzini
2025-03-06 14:42       ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8l_hn0TYozBtn--@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).