From: "Anthony PERARD" <anthony.perard@vates.tech>
To: "Pierrick Bouvier" <pierrick.bouvier@linaro.org>
Cc: qemu-devel@nongnu.org, "Paul Durrant" <paul@xen.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
xen-devel@lists.xenproject.org, "Peter Xu" <peterx@redhat.com>,
alex.bennee@linaro.org, manos.pitsidianakis@linaro.org,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-ppc@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
kvm@vger.kernel.org, "David Hildenbrand" <david@redhat.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Weiwei Li" <liwei1518@gmail.com>,
qemu-riscv@nongnu.org,
"Alistair Francis" <alistair.francis@wdc.com>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Nicholas Piggin" <npiggin@gmail.com>
Subject: Re: [PATCH v4 12/17] hw/xen: add stubs for various functions
Date: Fri, 14 Mar 2025 13:35:02 +0000 [thread overview]
Message-ID: <Z9Qwg4PC_1bEaOLK@l14> (raw)
In-Reply-To: <20250313163903.1738581-13-pierrick.bouvier@linaro.org>
On Thu, Mar 13, 2025 at 09:38:58AM -0700, Pierrick Bouvier wrote:
> Those functions are used by system/physmem.c, and are called only if
> xen is enabled (which happens only if CONFIG_XEN is not set).
You mean, 's/is not set/is set/'?
>
> So we can crash in case those are called.
>
> Acked-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
> ---
> diff --git a/hw/xen/xen_stubs.c b/hw/xen/xen_stubs.c
> new file mode 100644
> index 00000000000..19cee84bbb4
> --- /dev/null
> +++ b/hw/xen/xen_stubs.c
> +
> +void xen_invalidate_map_cache(void)
> +{
Is this stub actually necessary? xen_invalidate_map_cache() doesn't
seems to be used outside of xen's code.
In anycase:
Acked-by: Anthony PERARD <anthony.perard@vates.tech>
Thanks,
--
Anthony Perard | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
next prev parent reply other threads:[~2025-03-14 13:53 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 16:38 [PATCH v4 00/17] make system memory API available for common code Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 01/17] exec/tswap: target code can use TARGET_BIG_ENDIAN instead of target_words_bigendian() Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 02/17] exec/tswap: implement {ld, st}.*_p as functions instead of macros Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 03/17] exec/memory_ldst: extract memory_ldst declarations from cpu-all.h Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 04/17] exec/memory_ldst_phys: extract memory_ldst_phys " Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 05/17] exec/memory.h: make devend_memop "target defines" agnostic Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 06/17] codebase: prepare to remove cpu.h from exec/exec-all.h Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 07/17] exec/exec-all: remove dependency on cpu.h Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 08/17] exec/memory-internal: " Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 09/17] exec/ram_addr: " Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 10/17] system/kvm: make kvm_flush_coalesced_mmio_buffer() accessible for common code Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 11/17] exec/ram_addr: call xen_hvm_modified_memory only if xen is enabled Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 12/17] hw/xen: add stubs for various functions Pierrick Bouvier
2025-03-14 13:35 ` Anthony PERARD [this message]
2025-03-14 17:20 ` Pierrick Bouvier
2025-03-13 16:38 ` [PATCH v4 13/17] system/physmem: compilation unit is now common to all targets Pierrick Bouvier
2025-03-13 16:39 ` [PATCH v4 14/17] include/exec/memory: extract devend_big_endian from devend_memop Pierrick Bouvier
2025-03-13 16:39 ` [PATCH v4 15/17] include/exec/memory: move devend functions to memory-internal.h Pierrick Bouvier
2025-03-13 16:47 ` Richard Henderson
2025-03-13 16:39 ` [PATCH v4 16/17] system/memory: make compilation unit common Pierrick Bouvier
2025-03-13 16:39 ` [PATCH v4 17/17] system/ioport: " Pierrick Bouvier
2025-03-13 16:42 ` [PATCH v4 00/17] make system memory API available for common code Pierrick Bouvier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9Qwg4PC_1bEaOLK@l14 \
--to=anthony.perard@vates.tech \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=danielhb413@gmail.com \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=harshpb@linux.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=liwei1518@gmail.com \
--cc=manos.pitsidianakis@linaro.org \
--cc=npiggin@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=ysato@users.sourceforge.jp \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).