From: Yao Zi <ziyao@disroot.org>
To: Bibo Mao <maobibo@loongson.cn>,
Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] util/loongarch64: Add clang compiler support
Date: Fri, 14 Mar 2025 17:19:57 +0000 [thread overview]
Message-ID: <Z9RlPak0A9rjci0X@pie.lan> (raw)
In-Reply-To: <20250307011339.2246600-1-maobibo@loongson.cn>
On Fri, Mar 07, 2025 at 09:13:39AM +0800, Bibo Mao wrote:
> Float register name f0 - f31 is not recognized with clang compiler
> with LoongArch64 target, its name should be $f0 - $f31. It is ok
> for both gcc and clang compiler.
Sorry I didn't search the list carefully and sent a similar patch[1].
Apart from preventing the disk tools to be built, this issue affects
several headers used by linux-user emulators as well. IMHO this should
be fixed, too, or my patch could be taken.
Sorry for the inconvenience,
Yao Zi
[1]: https://lore.kernel.org/all/20250314033150.53268-3-ziyao@disroot.org/
> Signed-off-by: Bibo Mao <maobibo@loongson.cn>
> ---
> host/include/loongarch64/host/bufferiszero.c.inc | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/host/include/loongarch64/host/bufferiszero.c.inc b/host/include/loongarch64/host/bufferiszero.c.inc
> index 69891eac80..bb2598fdc3 100644
> --- a/host/include/loongarch64/host/bufferiszero.c.inc
> +++ b/host/include/loongarch64/host/bufferiszero.c.inc
> @@ -61,7 +61,8 @@ static bool buffer_is_zero_lsx(const void *buf, size_t len)
> "2:"
> : "=&r"(ret), "+r"(p)
> : "r"(buf), "r"(e), "r"(l)
> - : "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7", "f8", "fcc0");
> + : "$f0", "$f1", "$f2", "$f3", "$f4", "$f5", "$f6", "$f7", "$f8",
> + "$fcc0");
>
> return ret;
> }
> @@ -119,7 +120,8 @@ static bool buffer_is_zero_lasx(const void *buf, size_t len)
> "3:"
> : "=&r"(ret), "+r"(p)
> : "r"(buf), "r"(e), "r"(l)
> - : "f0", "f1", "f2", "f3", "f4", "f5", "f6", "f7", "f8", "fcc0");
> + : "$f0", "$f1", "$f2", "$f3", "$f4", "$f5", "$f6", "$f7", "$f8",
> + "$fcc0");
>
> return ret;
> }
>
> base-commit: 661c2e1ab29cd9c4d268ae3f44712e8d421c0e56
> --
> 2.39.3
next prev parent reply other threads:[~2025-03-14 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 1:13 [PATCH] util/loongarch64: Add clang compiler support Bibo Mao
2025-03-14 17:19 ` Yao Zi [this message]
2025-03-17 1:14 ` bibo mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9RlPak0A9rjci0X@pie.lan \
--to=ziyao@disroot.org \
--cc=maobibo@loongson.cn \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).