From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org
Subject: Re: [PATCH v2 10/14] rust/vmstate: Support vmstate_validate
Date: Tue, 18 Mar 2025 20:23:06 +0800 [thread overview]
Message-ID: <Z9llqtHLLTJIju/j@intel.com> (raw)
In-Reply-To: <9e8743b8-99b2-4aab-84de-7630edcc7e10@redhat.com>
> /// This macro can be used (by just passing it a type) to forward the `VMState`
> @@ -572,9 +548,9 @@ const fn phantom__<T>(_: &T) -> ::core::marker::PhantomData<T> {
> }
> Some(test_cb_builder__::<$struct_name, _>(phantom__(&$test_fn)))
> },
I want to keep the comment here as C version did, because there's an array flag :
// Though VMS_ARRAY is set, the num is 0: no data, only run test_fn callback
> + flags: VMStateFlags(VMStateFlags::VMS_MUST_EXIST.0 | VMStateFlags::VMS_ARRAY.0),
> ..$crate::zeroable::Zeroable::ZERO
> }
> - .with_validate_flag()
> };
> }
>
> Otherwise the series looks great, thanks!
Let me refresh the v3. :-)
Thanks,
Zhao
next prev parent reply other threads:[~2025-03-18 12:04 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 8:32 [PATCH v2 00/14] rust/vmstate: Clean up, fix, enhance & test Zhao Liu
2025-03-18 8:32 ` [PATCH v2 01/14] rust/vmstate: Remove unnecessary unsafe Zhao Liu
2025-03-18 8:32 ` [PATCH v2 02/14] rust/vmstate: Fix num_offset in vmstate macros Zhao Liu
2025-03-18 8:32 ` [PATCH v2 03/14] rust/vmstate: Fix num field when varray flags are set Zhao Liu
2025-03-18 8:32 ` [PATCH v2 04/14] rust/vmstate: Fix size field of VMStateField with VMS_ARRAY_OF_POINTER flag Zhao Liu
2025-03-18 8:32 ` [PATCH v2 05/14] rust/vmstate: Fix type check for varray in vmstate_struct Zhao Liu
2025-03-18 8:32 ` [PATCH v2 06/14] rust/vmstate: Fix "cannot infer type" error " Zhao Liu
2025-03-18 8:32 ` [PATCH v2 07/14] rust/vmstate: Fix unnecessary VMState bound of with_varray_flag() Zhao Liu
2025-03-18 8:32 ` [PATCH v2 08/14] rust/vmstate: Relax array check when build varray in vmstate_struct Zhao Liu
2025-03-18 8:32 ` [PATCH v2 09/14] rust/vmstate: Re-implement VMState trait for timer binding Zhao Liu
2025-03-18 8:32 ` [PATCH v2 10/14] rust/vmstate: Support vmstate_validate Zhao Liu
2025-03-18 10:11 ` Paolo Bonzini
2025-03-18 12:23 ` Zhao Liu [this message]
2025-03-18 12:32 ` Paolo Bonzini
2025-03-18 13:07 ` Zhao Liu
2025-03-18 8:32 ` [PATCH v2 11/14] rust/vmstate: Add unit test for vmstate_of macro Zhao Liu
2025-03-18 8:32 ` [PATCH v2 12/14] rust/vmstate: Add unit test for vmstate_{of|struct} macro Zhao Liu
2025-03-18 8:32 ` [PATCH v2 13/14] rust/vmstate: Add unit test for pointer case Zhao Liu
2025-03-18 8:32 ` [PATCH v2 14/14] rust/vmstate: Add unit test for vmstate_validate Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9llqtHLLTJIju/j@intel.com \
--to=zhao1.liu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).