From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29060C28B30 for ; Thu, 20 Mar 2025 17:39:30 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tvJr5-00012y-7f; Thu, 20 Mar 2025 13:38:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvJr0-00012C-Ac for qemu-devel@nongnu.org; Thu, 20 Mar 2025 13:38:50 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tvJqx-0008JA-Gm for qemu-devel@nongnu.org; Thu, 20 Mar 2025 13:38:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742492324; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3HGmP/nZ1WUqfuehqTmOqmEHKWq1owGBywsnymNLCxA=; b=SKu8HHQyVydmKajiBYDBc3HWEE90v17Wv5pTHoA5lstmRPC8G1RKIhV+GslnbMSAJxBgeg k6uzmdoqs4oqlbFovG1p4hvi6wWOHW9mthIraQWJU1b1AAGTNNK/XrrflFLw5BOWVKIvLm KwryWfH1QfoRHVoFOVjFRvg6ufSSEPk= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-yiePbddbNGeFixm-4hGgCg-1; Thu, 20 Mar 2025 13:38:39 -0400 X-MC-Unique: yiePbddbNGeFixm-4hGgCg-1 X-Mimecast-MFC-AGG-ID: yiePbddbNGeFixm-4hGgCg_1742492318 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 18C221800263; Thu, 20 Mar 2025 17:38:38 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.62]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E35591955BFE; Thu, 20 Mar 2025 17:38:36 +0000 (UTC) Date: Thu, 20 Mar 2025 17:38:33 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: qemu-devel@nongnu.org Cc: Laurent Vivier Subject: Re: [PATCH] linux-user: fix resource leaks in gen-vdso Message-ID: References: <20250219100336.1696758-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250219100336.1696758-1-berrange@redhat.com> User-Agent: Mutt/2.2.13 (2024-03-09) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.332, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org ping, any thoughts on this patch On Wed, Feb 19, 2025 at 10:03:36AM +0000, Daniel P. Berrangé wrote: > There are a number of resource leaks in gen-vdso. In theory they are > harmless because this is a short lived process, but when building QEMU > with --extra-cflags="-fsanitize=address" problems ensure. The gen-vdso > program is run as part of the build, and that aborts due to the > sanitizer identifying memory leaks, leaving QEMU unbuildable. > > FAILED: libqemu-x86_64-linux-user.a.p/vdso.c.inc > /var/home/berrange/src/virt/qemu/build/linux-user/gen-vdso -o libqemu-x86_64-linux-user.a.p/vdso.c.inc ../linux-user/x86_64/vdso.so > > ================================================================= > ==1696332==ERROR: LeakSanitizer: detected memory leaks > > Direct leak of 2968 byte(s) in 1 object(s) allocated from: > #0 0x56495873f1f3 (/var/home/berrange/src/virt/qemu/build/linux-user/gen-vdso+0xa11f3) (BuildId: b69e241ad44719b6f3934f3c71dfc6727e8bdb12) > #1 0x564958780b90 (/var/home/berrange/src/virt/qemu/build/linux-user/gen-vdso+0xe2b90) (BuildId: b69e241ad44719b6f3934f3c71dfc6727e8bdb12) > > This complaint is about the 'buf' variable, however, the FILE objects > are also leaked in some error scenarios, so this fix refactors the > cleanup paths to fix all leaks. For completeness it also reports an > error if fclose() fails on 'inf'. > > Signed-off-by: Daniel P. Berrangé > --- > linux-user/gen-vdso.c | 29 +++++++++++++++++------------ > 1 file changed, 17 insertions(+), 12 deletions(-) > > diff --git a/linux-user/gen-vdso.c b/linux-user/gen-vdso.c > index 721f38d5a3..88d94b19eb 100644 > --- a/linux-user/gen-vdso.c > +++ b/linux-user/gen-vdso.c > @@ -56,13 +56,14 @@ static unsigned rt_sigreturn_addr; > > int main(int argc, char **argv) > { > - FILE *inf, *outf; > + FILE *inf = NULL, *outf = NULL; > long total_len; > const char *prefix = "vdso"; > const char *inf_name; > const char *outf_name = NULL; > - unsigned char *buf; > + unsigned char *buf = NULL; > bool need_bswap; > + int ret = EXIT_FAILURE; > > while (1) { > int opt = getopt(argc, argv, "o:p:r:s:"); > @@ -129,7 +130,6 @@ int main(int argc, char **argv) > fprintf(stderr, "%s: incomplete read\n", inf_name); > return EXIT_FAILURE; > } > - fclose(inf); > > /* > * Identify which elf flavor we're processing. > @@ -205,19 +205,24 @@ int main(int argc, char **argv) > fprintf(outf, " .rt_sigreturn_ofs = 0x%x,\n", rt_sigreturn_addr); > fprintf(outf, "};\n"); > > - /* > - * Everything should have gone well. > - */ > - if (fclose(outf)) { > - goto perror_outf; > - } > - return EXIT_SUCCESS; > + ret = EXIT_SUCCESS; > + > + cleanup: > + free(buf); > + > + if (outf && > + fclose(outf) != 0) > + ret = EXIT_FAILURE; > + if (inf && > + fclose(inf) != 0) > + ret = EXIT_FAILURE; > + return ret; > > perror_inf: > perror(inf_name); > - return EXIT_FAILURE; > + goto cleanup; > > perror_outf: > perror(outf_name); > - return EXIT_FAILURE; > + goto cleanup; > } > -- > 2.47.1 > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|