From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Laurent Vivier" <lvivier@redhat.com>,
"Thomas Huth" <thuth@redhat.com>
Subject: Re: [PATCH v3 11/18] ui/sdl: get the GL context from the window
Date: Mon, 13 Mar 2023 10:18:41 +0000 [thread overview]
Message-ID: <ZA74gQSEsSRQiGo7@redhat.com> (raw)
In-Reply-To: <20230313101207.375125-12-marcandre.lureau@redhat.com>
On Mon, Mar 13, 2023 at 02:12:00PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> There is no guarantee to have a current GL context here. The current
> code seems to rely on the renderer using a GL backend, and to set a
> current GL context. But this is not always the case, for example if the
> renderer backend is DirectX.
>
> This change is enough to fix using virgl with sdl2 on win32, on my setup.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/sdl2.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-03-13 10:19 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 10:11 [PATCH v3 00/18] ui: dbus & misc fixes marcandre.lureau
2023-03-13 10:11 ` [PATCH v3 01/18] ui/dbus: initialize cursor_fb marcandre.lureau
2023-03-13 10:11 ` [PATCH v3 02/18] ui/dbus: unregister clipboard on connection close marcandre.lureau
2023-03-13 10:11 ` [PATCH v3 03/18] audio/dbus: there are no sender for p2p mode marcandre.lureau
2023-03-13 10:11 ` [PATCH v3 04/18] ui/dbus: set mouse is-absolute during console creation marcandre.lureau
2023-03-13 10:11 ` [PATCH v3 05/18] meson: ensure dbus-display generated code is built before other units marcandre.lureau
2023-03-13 10:11 ` [PATCH v3 06/18] ui: rename cursor_{put->unref} marcandre.lureau
2023-03-13 10:11 ` [PATCH v3 07/18] ui: rename cursor_{get->ref}, return it marcandre.lureau
2023-03-13 10:11 ` [PATCH v3 08/18] ui: keep current cursor with QemuConsole marcandre.lureau
2023-03-13 10:11 ` [PATCH v3 09/18] ui: set cursor upon listener registration marcandre.lureau
2023-03-13 10:11 ` [PATCH v3 10/18] ui: set cursor position " marcandre.lureau
2023-03-13 10:12 ` [PATCH v3 11/18] ui/sdl: get the GL context from the window marcandre.lureau
2023-03-13 10:18 ` Daniel P. Berrangé [this message]
2023-03-13 10:12 ` [PATCH v3 12/18] ui/shader: fix #version directive must occur on first line marcandre.lureau
2023-03-13 10:12 ` [PATCH v3 13/18] ui/egl: print EGL error, helping debugging marcandre.lureau
2023-03-13 10:12 ` [PATCH v3 14/18] ui/sdl: add QEMU_ENABLE_SDL_LOGGING setting/environment marcandre.lureau
2023-03-13 10:20 ` Daniel P. Berrangé
2023-03-13 10:12 ` [PATCH v3 15/18] ui/sdl: try to instantiate the matching opengl renderer marcandre.lureau
2023-03-13 10:21 ` Daniel P. Berrangé
2023-03-13 10:12 ` [PATCH v3 16/18] ui: introduce egl_init() marcandre.lureau
2023-03-13 10:22 ` Daniel P. Berrangé
2023-03-13 10:12 ` [PATCH v3 17/18] ui/dbus: do not require opengl & gbm marcandre.lureau
2023-03-13 10:23 ` Daniel P. Berrangé
2023-03-13 10:12 ` [PATCH v3 18/18] ui/dbus: restrict opengl to gbm-enabled config marcandre.lureau
2023-03-13 10:23 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA74gQSEsSRQiGo7@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).