From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98B5AC74A4B for ; Mon, 13 Mar 2023 10:22:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pbfJn-0008T0-6r; Mon, 13 Mar 2023 06:22:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbfJl-0008So-Lp for qemu-devel@nongnu.org; Mon, 13 Mar 2023 06:22:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbfJg-0005w2-Au for qemu-devel@nongnu.org; Mon, 13 Mar 2023 06:22:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678702927; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9IVx1s5LhFYxDiBRCrGrjOYVEWheTMD3WvWw5ZGl97w=; b=itVNEKFzA2wW+ltJ4vPygUmzY4D2qmGZyWJud8CAF2PQ294hWu9UlE/FKugrvjLDpQjMFl XXaX9OUUaFutQyL+GTSligm6ommiGFgi/ZvyN1vHn0yKZ3MNsDZPfzWteK6PdQvDzs/CqQ /KKOskWjd9UdMTrmDdPvJy7FHWY71IM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-531-nSSB8-jMNXWHqGhpeBxK4g-1; Mon, 13 Mar 2023 06:22:06 -0400 X-MC-Unique: nSSB8-jMNXWHqGhpeBxK4g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C02063C10C60; Mon, 13 Mar 2023 10:22:05 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7B8831121315; Mon, 13 Mar 2023 10:22:04 +0000 (UTC) Date: Mon, 13 Mar 2023 10:22:02 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Laurent Vivier , Thomas Huth Subject: Re: [PATCH v3 16/18] ui: introduce egl_init() Message-ID: References: <20230313101207.375125-1-marcandre.lureau@redhat.com> <20230313101207.375125-17-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230313101207.375125-17-marcandre.lureau@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Mar 13, 2023 at 02:12:05PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > Future patches will introduce EGL support on win32 (too late for 8.0 > though). Having a common place for EGL initialization and error handling > will make it simpler. > > Signed-off-by: Marc-André Lureau > --- > include/ui/egl-helpers.h | 2 ++ > ui/dbus.c | 7 +------ > ui/egl-headless.c | 16 ++++++++-------- > ui/egl-helpers.c | 24 ++++++++++++++++++++++++ > ui/spice-core.c | 7 +------ > 5 files changed, 36 insertions(+), 20 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|