From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D61C9C678D4 for ; Fri, 3 Mar 2023 09:12:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pY1Sf-0001Wu-S5; Fri, 03 Mar 2023 04:12:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY1Se-0001Wd-HM for qemu-devel@nongnu.org; Fri, 03 Mar 2023 04:12:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pY1Sc-0005kc-Ul for qemu-devel@nongnu.org; Fri, 03 Mar 2023 04:12:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677834737; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l2P6J71soGdgtBF1ShvvXWeNrJAdJT8OWd3tq7wtHR8=; b=VELoiIV4hMwYG3xgsRgftoSd1TUE/XMaYaqT76dNt8vWP96KrPN+C3ZSMuV4VYwWNX/Q02 DHol2LQi3rcyfRSuTMbhUpzbFUgK+X0jGNX2nckHEAO7nI5SyiU+jSvlPnuTZdI1fmD//y IGpG35hpzXod/mtuDLxs8youCM172TE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-17-5w8nEx_VNjCXPyXcoRPzOQ-1; Fri, 03 Mar 2023 04:12:15 -0500 X-MC-Unique: 5w8nEx_VNjCXPyXcoRPzOQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 229B8185A78B; Fri, 3 Mar 2023 09:12:15 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.53]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 076BC492C18; Fri, 3 Mar 2023 09:12:13 +0000 (UTC) Date: Fri, 3 Mar 2023 09:12:10 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Juan Quintela Cc: Peter Maydell , qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , "Dr. David Alan Gilbert" , Thomas Huth Subject: Re: [PATCH] tests/qtest/migration-test: Disable migration/multifd/tcp/plain/cancel Message-ID: References: <20230302172211.4146376-1-peter.maydell@linaro.org> <87edq6i4jf.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87edq6i4jf.fsf@secure.mitica> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Mar 03, 2023 at 10:10:28AM +0100, Juan Quintela wrote: > Daniel P. Berrangé wrote: > > On Thu, Mar 02, 2023 at 05:22:11PM +0000, Peter Maydell wrote: > >> migration-test has been flaky for a long time, both in CI and > >> otherwise: > >> > >> https://gitlab.com/qemu-project/qemu/-/jobs/3806090216 > >> (a FreeBSD job) > >> 32/648 ERROR:../tests/qtest/migration-helpers.c:205:wait_for_migration_status: assertion failed: (g_test_timer_elapsed() < MIGRATION_STATUS_WAIT_TIMEOUT) ERROR > >> > >> on a local macos x86 box: > >> ▶ 34/621 ERROR:../../tests/qtest/migration-helpers.c:151:migrate_query_not_failed: assertion failed: (!g_str_equal(status, "failed")) ERROR > >> 34/621 qemu:qtest+qtest-i386 / qtest-i386/migration-test ERROR 168.12s killed by signal 6 SIGABRT > >> ――――――――――――――――――――――――――――――――――――― ✀ ――――――――――――――――――――――――――――――――――――― > >> stderr: > >> qemu-system-i386: Failed to peek at channel > >> query-migrate shows failed migration: Unable to write to socket: Broken pipe > >> ** > >> ERROR:../../tests/qtest/migration-helpers.c:151:migrate_query_not_failed: assertion failed: (!g_str_equal(status, "failed")) > >> > >> (test program exited with status code -6) > >> ―――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――――― > >> > >> ▶ 37/621 ERROR:../../tests/qtest/migration-helpers.c:151:migrate_query_not_failed: assertion failed: (!g_str_equal(status, "failed")) ERROR > >> 37/621 qemu:qtest+qtest-x86_64 / qtest-x86_64/migration-test ERROR 174.37s killed by signal 6 SIGABRT > >> ――――――――――――――――――――――――――――――――――――― ✀ ――――――――――――――――――――――――――――――――――――― > >> stderr: > >> query-migrate shows failed migration: Unable to write to socket: Broken pipe > >> ** > >> ERROR:../../tests/qtest/migration-helpers.c:151:migrate_query_not_failed: assertion failed: (!g_str_equal(status, "failed")) > >> > >> (test program exited with status code -6) > >> > >> In the cases where I've looked at the underlying log, this seems to > >> be in the migration/multifd/tcp/plain/cancel subtest. Disable that > >> specific subtest by default until somebody can track down the > >> underlying cause. Enthusiasts can opt back in by setting > >> QEMU_TEST_FLAKY_TESTS=1 in their environment. > > > > No objection to disabling the test. Given the many multifd fixes we > > have seen, I fear that unlikely many of the flakey tests, this is > > not merely a test problem, but rather has a decent chance of being > > a real bug in migration code. > > What is really weird with this failure is that: > - it only happens on non-x86 That doesn't seem right as the two reports Peter has above are both x86 > - on code that is not arch dependent > - on cancel, what we really do there is close fd's for the multifd > channel threads to get out of the recv, i.e. again, nothing that > should be arch dependent. > > As said in the other email, I expect to get back access to ARM servers > next week. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|