* [PATCH V2] migration: fix populate_vfio_info
@ 2023-02-07 19:02 Steve Sistare
2023-03-07 11:32 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 4+ messages in thread
From: Steve Sistare @ 2023-02-07 19:02 UTC (permalink / raw)
To: qemu-devel
Cc: Marc-André Lureau, Dr. David Alan Gilbert, Thomas Huth,
Steve Sistare
Include CONFIG_DEVICES so that populate_vfio_info is instantiated for
CONFIG_VFIO. Without it, the 'info migrate' command never returns
info about vfio.
Fixes: 43bd0bf30f ("migration: Move populate_vfio_info() into a separate file")
Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
migration/target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/target.c b/migration/target.c
index 907ebf0..00ca007 100644
--- a/migration/target.c
+++ b/migration/target.c
@@ -8,6 +8,7 @@
#include "qemu/osdep.h"
#include "qapi/qapi-types-migration.h"
#include "migration.h"
+#include CONFIG_DEVICES
#ifdef CONFIG_VFIO
#include "hw/vfio/vfio-common.h"
@@ -17,7 +18,6 @@ void populate_vfio_info(MigrationInfo *info)
{
#ifdef CONFIG_VFIO
if (vfio_mig_active()) {
- info->has_vfio = true;
info->vfio = g_malloc0(sizeof(*info->vfio));
info->vfio->transferred = vfio_mig_bytes_transferred();
}
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH V2] migration: fix populate_vfio_info
2023-02-07 19:02 [PATCH V2] migration: fix populate_vfio_info Steve Sistare
@ 2023-03-07 11:32 ` Dr. David Alan Gilbert
2023-03-07 14:04 ` Steven Sistare
0 siblings, 1 reply; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2023-03-07 11:32 UTC (permalink / raw)
To: Steve Sistare, quintela; +Cc: qemu-devel, Marc-André Lureau, Thomas Huth
* Steve Sistare (steven.sistare@oracle.com) wrote:
> Include CONFIG_DEVICES so that populate_vfio_info is instantiated for
> CONFIG_VFIO. Without it, the 'info migrate' command never returns
> info about vfio.
>
> Fixes: 43bd0bf30f ("migration: Move populate_vfio_info() into a separate file")
> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> migration/target.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/target.c b/migration/target.c
> index 907ebf0..00ca007 100644
> --- a/migration/target.c
> +++ b/migration/target.c
> @@ -8,6 +8,7 @@
> #include "qemu/osdep.h"
> #include "qapi/qapi-types-migration.h"
> #include "migration.h"
> +#include CONFIG_DEVICES
>
> #ifdef CONFIG_VFIO
> #include "hw/vfio/vfio-common.h"
> @@ -17,7 +18,6 @@ void populate_vfio_info(MigrationInfo *info)
> {
> #ifdef CONFIG_VFIO
> if (vfio_mig_active()) {
> - info->has_vfio = true;
Why this removal?
Dave
> info->vfio = g_malloc0(sizeof(*info->vfio));
> info->vfio->transferred = vfio_mig_bytes_transferred();
> }
> --
> 1.8.3.1
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V2] migration: fix populate_vfio_info
2023-03-07 11:32 ` Dr. David Alan Gilbert
@ 2023-03-07 14:04 ` Steven Sistare
2023-03-07 14:55 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 4+ messages in thread
From: Steven Sistare @ 2023-03-07 14:04 UTC (permalink / raw)
To: Dr. David Alan Gilbert, quintela
Cc: qemu-devel, Marc-André Lureau, Thomas Huth
On 3/7/2023 6:32 AM, Dr. David Alan Gilbert wrote:
> * Steve Sistare (steven.sistare@oracle.com) wrote:
>> Include CONFIG_DEVICES so that populate_vfio_info is instantiated for
>> CONFIG_VFIO. Without it, the 'info migrate' command never returns
>> info about vfio.
>>
>> Fixes: 43bd0bf30f ("migration: Move populate_vfio_info() into a separate file")
>> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
>> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>> ---
>> migration/target.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/migration/target.c b/migration/target.c
>> index 907ebf0..00ca007 100644
>> --- a/migration/target.c
>> +++ b/migration/target.c
>> @@ -8,6 +8,7 @@
>> #include "qemu/osdep.h"
>> #include "qapi/qapi-types-migration.h"
>> #include "migration.h"
>> +#include CONFIG_DEVICES
>>
>> #ifdef CONFIG_VFIO
>> #include "hw/vfio/vfio-common.h"
>> @@ -17,7 +18,6 @@ void populate_vfio_info(MigrationInfo *info)
>> {
>> #ifdef CONFIG_VFIO
>> if (vfio_mig_active()) {
>> - info->has_vfio = true;
>
> Why this removal?
The has_vfio member was removed by:
720a252c2651 ("qapi migration: Elide redundant has_FOO in generated C")
The stale reference was not noticed at the time because the ifdef was never true.
- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V2] migration: fix populate_vfio_info
2023-03-07 14:04 ` Steven Sistare
@ 2023-03-07 14:55 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 4+ messages in thread
From: Dr. David Alan Gilbert @ 2023-03-07 14:55 UTC (permalink / raw)
To: Steven Sistare; +Cc: quintela, qemu-devel, Marc-André Lureau, Thomas Huth
* Steven Sistare (steven.sistare@oracle.com) wrote:
> On 3/7/2023 6:32 AM, Dr. David Alan Gilbert wrote:
> > * Steve Sistare (steven.sistare@oracle.com) wrote:
> >> Include CONFIG_DEVICES so that populate_vfio_info is instantiated for
> >> CONFIG_VFIO. Without it, the 'info migrate' command never returns
> >> info about vfio.
> >>
> >> Fixes: 43bd0bf30f ("migration: Move populate_vfio_info() into a separate file")
> >> Signed-off-by: Steve Sistare <steven.sistare@oracle.com>
> >> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> >> ---
> >> migration/target.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/migration/target.c b/migration/target.c
> >> index 907ebf0..00ca007 100644
> >> --- a/migration/target.c
> >> +++ b/migration/target.c
> >> @@ -8,6 +8,7 @@
> >> #include "qemu/osdep.h"
> >> #include "qapi/qapi-types-migration.h"
> >> #include "migration.h"
> >> +#include CONFIG_DEVICES
> >>
> >> #ifdef CONFIG_VFIO
> >> #include "hw/vfio/vfio-common.h"
> >> @@ -17,7 +18,6 @@ void populate_vfio_info(MigrationInfo *info)
> >> {
> >> #ifdef CONFIG_VFIO
> >> if (vfio_mig_active()) {
> >> - info->has_vfio = true;
> >
> > Why this removal?
>
> The has_vfio member was removed by:
> 720a252c2651 ("qapi migration: Elide redundant has_FOO in generated C")
> The stale reference was not noticed at the time because the ifdef was never true.
Oh ok, that makes sense,
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> - Steve
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-07 14:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-07 19:02 [PATCH V2] migration: fix populate_vfio_info Steve Sistare
2023-03-07 11:32 ` Dr. David Alan Gilbert
2023-03-07 14:04 ` Steven Sistare
2023-03-07 14:55 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).