From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [PATCH] .editorconfig: set max line at 70 chars for QAPI files
Date: Tue, 7 Mar 2023 12:40:22 +0000 [thread overview]
Message-ID: <ZAcwtl8N+ruzH4qj@redhat.com> (raw)
In-Reply-To: <20230307123027.2485499-1-marcandre.lureau@redhat.com>
On Tue, Mar 07, 2023 at 04:30:27PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> This seems to be the preferred style.
>
> The EditorConfig property is not supported by all editors:
> https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#max_line_length
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> .editorconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.editorconfig b/.editorconfig
> index 7303759ed7..8c5ebc6a1b 100644
> --- a/.editorconfig
> +++ b/.editorconfig
> @@ -47,3 +47,4 @@ emacs_mode = glsl
> [*.json]
> indent_style = space
> emacs_mode = python
> +max_line_length = 70
Why 70 as a hard limit ? I thought QEMU policy was that 80 was a soft
limit and we were happy with 90 if it avoided wrapping that would hurt
readability.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-03-07 12:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 12:30 [PATCH] .editorconfig: set max line at 70 chars for QAPI files marcandre.lureau
2023-03-07 12:40 ` Daniel P. Berrangé [this message]
2023-03-07 12:55 ` Marc-André Lureau
2023-03-07 13:09 ` Markus Armbruster
2023-03-21 7:30 ` Marc-André Lureau
2023-03-21 13:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAcwtl8N+ruzH4qj@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).