From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AB625C64EC4 for ; Fri, 10 Mar 2023 10:00:32 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paZXw-00012Q-Ti; Fri, 10 Mar 2023 05:00:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paZXq-00012B-T2 for qemu-devel@nongnu.org; Fri, 10 Mar 2023 05:00:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paZXo-00051K-SN for qemu-devel@nongnu.org; Fri, 10 Mar 2023 05:00:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678442412; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RLEiFt9iH3GGUo7uMNtoiY7kxbR9sACVw8RaL/1trG4=; b=D1AhQC76XwE7SWRhMRGuuIkK2En3Pb+95xgGnT59GcFhGsqiziN6DjcfGCQrnPKch34If0 HYrbGmZ8NlsOQA4zufSjqqfyjNq9Qtql5OjsuGvp7SeO3qrBkd3QfcFRwv8Saa8P4MT5Ms 2obY2E/E084N4fpzuhbnm2SArhkE3P4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-594-2iY6_1afMBK25E-o6LPoPA-1; Fri, 10 Mar 2023 05:00:08 -0500 X-MC-Unique: 2iY6_1afMBK25E-o6LPoPA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 701C829AA3BD; Fri, 10 Mar 2023 10:00:08 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B6E0C40C945A; Fri, 10 Mar 2023 10:00:06 +0000 (UTC) Date: Fri, 10 Mar 2023 10:00:03 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Paolo Bonzini , Thomas Huth , Gerd Hoffmann , Laurent Vivier Subject: Re: [PATCH v2 11/18] ui/sdl: get the GL context from the window Message-ID: References: <20230307115637.2464377-1-marcandre.lureau@redhat.com> <20230307115637.2464377-12-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230307115637.2464377-12-marcandre.lureau@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Mar 07, 2023 at 03:56:30PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > There is no guarantee to have a current GL context here. The current > code seems to rely on the renderer using a GL backend, and to set a > current GL context. But this is not always the case, for example if the > renderer backend is DirectX. > > This change is enough to fix using virgl with sdl2 on win32, on my setup. > > Signed-off-by: Marc-André Lureau > --- > ui/sdl2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ui/sdl2.c b/ui/sdl2.c > index 8cb77416af..f259e4c4d1 100644 > --- a/ui/sdl2.c > +++ b/ui/sdl2.c > @@ -101,7 +101,7 @@ void sdl2_window_create(struct sdl2_console *scon) > flags); > scon->real_renderer = SDL_CreateRenderer(scon->real_window, -1, 0); > if (scon->opengl) { > - scon->winctx = SDL_GL_GetCurrentContext(); > + scon->winctx = SDL_GL_CreateContext(scon->real_window); IIUC, previously this borrowed a pointer to an existing context and so didn't need to free it. Now this is creating a new dedicated context, something must free this in sdl2_window_destroy. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|