From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PULL v2 08/18] ui: keep current cursor with QemuConsole
Date: Fri, 17 Mar 2023 17:34:40 +0000 [thread overview]
Message-ID: <ZBSksLx7EhkA1plf@redhat.com> (raw)
In-Reply-To: <20230313200134.503083-9-marcandre.lureau@redhat.com>
On Tue, Mar 14, 2023 at 12:01:24AM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Keeping the current cursor around is useful, not only for VNC, but for
> other displays. Let's move it down, see the following patches for other
> usages.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> include/ui/console.h | 1 +
> ui/vnc.h | 1 -
> ui/console.c | 8 ++++++++
> ui/vnc.c | 7 ++-----
> 4 files changed, 11 insertions(+), 6 deletions(-)
Unfortunately this commit appears to have casued a regresion leading
to a SEGV crash in VNC reported by a user:
https://gitlab.com/qemu-project/qemu/-/issues/1548
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-03-17 17:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 20:01 [PULL v2 00/18] Display patches marcandre.lureau
2023-03-13 20:01 ` [PULL v2 01/18] ui/dbus: initialize cursor_fb marcandre.lureau
2023-03-13 20:01 ` [PULL v2 02/18] ui/dbus: unregister clipboard on connection close marcandre.lureau
2023-03-13 20:01 ` [PULL v2 03/18] audio/dbus: there are no sender for p2p mode marcandre.lureau
2023-03-13 20:01 ` [PULL v2 04/18] ui/dbus: set mouse is-absolute during console creation marcandre.lureau
2023-03-13 20:01 ` [PULL v2 05/18] meson: ensure dbus-display generated code is built before other units marcandre.lureau
2023-03-13 20:01 ` [PULL v2 06/18] ui: rename cursor_{put->unref} marcandre.lureau
2023-03-13 20:01 ` [PULL v2 07/18] ui: rename cursor_{get->ref}, return it marcandre.lureau
2023-03-13 20:01 ` [PULL v2 08/18] ui: keep current cursor with QemuConsole marcandre.lureau
2023-03-17 17:34 ` Daniel P. Berrangé [this message]
2023-03-13 20:01 ` [PULL v2 09/18] ui: set cursor upon listener registration marcandre.lureau
2023-03-13 20:01 ` [PULL v2 10/18] ui: set cursor position " marcandre.lureau
2023-03-13 20:01 ` [PULL v2 11/18] ui/sdl: get the GL context from the window marcandre.lureau
2023-03-13 20:01 ` [PULL v2 12/18] ui/shader: fix #version directive must occur on first line marcandre.lureau
2023-03-13 20:01 ` [PULL v2 13/18] ui/egl: print EGL error, helping debugging marcandre.lureau
2023-03-13 20:01 ` [PULL v2 14/18] ui/sdl: add QEMU_ENABLE_SDL_LOGGING setting/environment marcandre.lureau
2023-03-13 20:01 ` [PULL v2 15/18] ui/sdl: try to instantiate the matching opengl renderer marcandre.lureau
2023-03-13 20:01 ` [PULL v2 16/18] ui: introduce egl_init() marcandre.lureau
2023-03-13 20:01 ` [PULL v2 17/18] ui/dbus: do not require opengl & gbm marcandre.lureau
2023-03-13 20:01 ` [PULL v2 18/18] ui/dbus: restrict opengl to gbm-enabled config marcandre.lureau
2023-03-24 15:25 ` Fabiano Rosas
2023-03-14 19:21 ` [PULL v2 00/18] Display patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBSksLx7EhkA1plf@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).