From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01714C6FD1D for ; Fri, 17 Mar 2023 17:35:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdDyg-0005wp-AF; Fri, 17 Mar 2023 13:34:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdDyf-0005v8-8w for qemu-devel@nongnu.org; Fri, 17 Mar 2023 13:34:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdDyd-00050r-L0 for qemu-devel@nongnu.org; Fri, 17 Mar 2023 13:34:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679074490; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ormTE2lLRJXcN5dZp0aF+vrKU34MfIwNVUyXwZ+juWA=; b=L9VnLXsq5gHUVcZCeYS4UzinLPeCKdlEUNWkMOhk2FDTgcK7xJZgnc4L/aaWmMVZSRRn3v iniJBRqH6KLNu7j/Clrynvb5DRamRZ2d6Ke/G7nLfZOBIB+24OkqOvyLSPLHnCM+s7+Y0C ZVjCrASTT8jNGB2UD4djkRmTYTCsqIM= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-417-JQ4tMv4_Pa-CE3-pvtsJYA-1; Fri, 17 Mar 2023 13:34:47 -0400 X-MC-Unique: JQ4tMv4_Pa-CE3-pvtsJYA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 01F731C05152; Fri, 17 Mar 2023 17:34:47 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.59]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 381AC40D1C7; Fri, 17 Mar 2023 17:34:44 +0000 (UTC) Date: Fri, 17 Mar 2023 17:34:40 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: marcandre.lureau@redhat.com Cc: qemu-devel@nongnu.org, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Thomas Huth , Gerd Hoffmann , Laurent Vivier , Paolo Bonzini Subject: Re: [PULL v2 08/18] ui: keep current cursor with QemuConsole Message-ID: References: <20230313200134.503083-1-marcandre.lureau@redhat.com> <20230313200134.503083-9-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230313200134.503083-9-marcandre.lureau@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Mar 14, 2023 at 12:01:24AM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau > > Keeping the current cursor around is useful, not only for VNC, but for > other displays. Let's move it down, see the following patches for other > usages. > > Signed-off-by: Marc-André Lureau > Reviewed-by: Daniel P. Berrangé > --- > include/ui/console.h | 1 + > ui/vnc.h | 1 - > ui/console.c | 8 ++++++++ > ui/vnc.c | 7 ++----- > 4 files changed, 11 insertions(+), 6 deletions(-) Unfortunately this commit appears to have casued a regresion leading to a SEGV crash in VNC reported by a user: https://gitlab.com/qemu-project/qemu/-/issues/1548 With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|