From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, Stefan Weil <sw@weilnetz.de>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 2/3] ui/spice: fix SOCKET handling regression
Date: Mon, 20 Mar 2023 12:10:44 +0000 [thread overview]
Message-ID: <ZBhNRHYrdrpGFwfO@redhat.com> (raw)
In-Reply-To: <20230320111412.1516419-3-marcandre.lureau@redhat.com>
On Mon, Mar 20, 2023 at 03:14:11PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Spice uses SOCKET on win32, but QEMU now uses file-descriptors.
>
> Fixes "8.0.0rc0 Regression: spicy windows doesn't open":
> https://gitlab.com/qemu-project/qemu/-/issues/1549
>
> Fixes: commit abe34282b ("win32: avoid mixing SOCKET and file descriptor space")
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> ui/spice-core.c | 29 +++++++++++++++++++++++++++--
> 1 file changed, 27 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-03-20 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 11:14 [PATCH 0/3] Fix Spice regression on win32 marcandre.lureau
2023-03-20 11:14 ` [PATCH 1/3] win32: add qemu_close_to_socket() marcandre.lureau
2023-03-20 12:10 ` Daniel P. Berrangé
2023-03-20 11:14 ` [PATCH 2/3] ui/spice: fix SOCKET handling regression marcandre.lureau
2023-03-20 12:10 ` Daniel P. Berrangé [this message]
2023-03-20 11:14 ` [PATCH 3/3] ui/dbus: fix passing SOCKET to GSocket API & leak marcandre.lureau
2023-03-20 12:17 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBhNRHYrdrpGFwfO@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).