From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C980FC6FD1D for ; Tue, 21 Mar 2023 15:21:24 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pedn2-0008IM-9d; Tue, 21 Mar 2023 11:20:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pedn0-0008Fl-CY for qemu-devel@nongnu.org; Tue, 21 Mar 2023 11:20:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pedmx-0008W1-9z for qemu-devel@nongnu.org; Tue, 21 Mar 2023 11:20:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679412032; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=it1sxSU4S5vJ5TNemHFBjV2CYha1znBhsh5fyiboaHc=; b=HaWD0Ij/MGJxbYtpHaRj7qCkgs9yu/rGbn0uFOa4+6aHuLoHqGqe46u5zBDLV9KQu3mCam 4tmm8I14GBjHo/RkIUBAnX9b737+RcdcXZnlZxAVOrf7LqXDDlqMvq7x6u/vBJcY84u2gS AZZqU8bg5P92zM5a06VVSSbV1msROeE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-256-UHzh_7b5NBa3nPL7S8eECA-1; Tue, 21 Mar 2023 11:20:26 -0400 X-MC-Unique: UHzh_7b5NBa3nPL7S8eECA-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 02A63867917; Tue, 21 Mar 2023 15:19:32 +0000 (UTC) Received: from redhat.com (unknown [10.33.37.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7ACF9492C13; Tue, 21 Mar 2023 15:19:30 +0000 (UTC) Date: Tue, 21 Mar 2023 15:19:28 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: Markus Armbruster , qemu-devel@nongnu.org, Pavel Dovgalyuk , "Dr. David Alan Gilbert" , Michael Roth , Stefan Berger , Paolo Bonzini , =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Juan Quintela , Gerd Hoffmann Subject: Re: [PATCH v3 2/3] qapi: Do not generate empty enum Message-ID: References: <20230315112811.22355-1-philmd@linaro.org> <20230315112811.22355-3-philmd@linaro.org> <87cz58ubcn.fsf@pond.sub.org> <873564spze.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Mar 21, 2023 at 03:31:56PM +0100, Philippe Mathieu-Daudé wrote: > On 16/3/23 15:57, Markus Armbruster wrote: > > Daniel P. Berrangé writes: > > > > > On Thu, Mar 16, 2023 at 01:31:04PM +0100, Markus Armbruster wrote: > > > > Philippe Mathieu-Daudé writes: > > > > > > > > > Per the C++ standard, empty enum are ill-formed. Do not generate > > > > The C standard. The C++ standard doesn't apply here :) > > I can't find how empty enums are considered by the C standard... The C standard doesn't really matter either. What we actually care about is whether GCC and CLang consider the empty enums to be permissible or not. or to put it another way... if it compiles, ship it :-) With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|