qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, "Brad Smith" <brad@comstyle.com>,
	"Thomas Huth" <thuth@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Kyle Evans" <kevans@freebsd.org>, "Warner Losh" <imp@bsdimp.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH 1/2] tests/vm: skip X11 in openbsd installation
Date: Wed, 22 Mar 2023 13:52:47 +0000	[thread overview]
Message-ID: <ZBsILyBjHfO8oB/O@redhat.com> (raw)
In-Reply-To: <d8fe0d24-03ee-4c4a-6886-36319eaa2948@linaro.org>

On Wed, Mar 22, 2023 at 02:38:13PM +0100, Philippe Mathieu-Daudé wrote:
> On 22/3/23 13:36, Daniel P. Berrangé wrote:
> > As a VM used only for automated testing there is no need to
> > install the X11 stack.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >   tests/vm/openbsd | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/tests/vm/openbsd b/tests/vm/openbsd
> > index eaeb201e91..6af7afac0d 100755
> > --- a/tests/vm/openbsd
> > +++ b/tests/vm/openbsd
> > @@ -106,8 +106,7 @@ class OpenBSDVM(basevm.BaseVM):
> >           self.console_wait("Password for root account")
> >           self.console_send("%s\n" % self._config["root_pass"])
> >           self.console_wait_send("Start sshd(8)",           "yes\n")
> > -        self.console_wait_send("X Window System",         "\n")
> > -        self.console_wait_send("xenodm",                  "\n")
> > +        self.console_wait_send("X Window System",         "no\n")
> 
> Wasn't this useful to link a X11-ready binary, even if only testing
> with -display=none?

I've just confirmed /usr/X11R6/include/X11/  still exists in the image
even after this change, as does /usr/X11R6/lib/

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  parent reply	other threads:[~2023-03-22 13:53 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-22 12:36 [PATCH 0/2] tests/vm: fix ENOSPC in the openbsd VM image Daniel P. Berrangé
2023-03-22 12:36 ` [PATCH 1/2] tests/vm: skip X11 in openbsd installation Daniel P. Berrangé
2023-03-22 12:43   ` Thomas Huth
2023-03-22 13:38   ` Philippe Mathieu-Daudé
2023-03-22 13:40     ` Thomas Huth
2023-03-22 13:46       ` Philippe Mathieu-Daudé
2023-03-22 15:20       ` Brad Smith
2023-03-22 15:29         ` Thomas Huth
2023-03-22 15:31         ` Daniel P. Berrangé
2023-03-22 13:52     ` Daniel P. Berrangé [this message]
2023-03-22 12:36 ` [PATCH 2/2] tests/vm: custom openbsd partitioning to increase /home space Daniel P. Berrangé
2023-03-22 12:45   ` Thomas Huth
2023-03-22 13:39   ` Philippe Mathieu-Daudé
2023-03-22 15:08 ` [PATCH 0/2] tests/vm: fix ENOSPC in the openbsd VM image Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZBsILyBjHfO8oB/O@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=bleal@redhat.com \
    --cc=brad@comstyle.com \
    --cc=imp@bsdimp.com \
    --cc=kevans@freebsd.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).