From: Klaus Jensen <its@irrelevant.dk>
To: Mateusz Kozlowski <kozlowski.mateuszpl@gmail.com>
Cc: qemu-devel@nongnu.org, mateusz.kozlowski@solidigm.com,
Keith Busch <kbusch@kernel.org>,
"open list:nvme" <qemu-block@nongnu.org>
Subject: Re: [PATCH] hw/nvme: Change alignment in dma functions for nvme_blk_*
Date: Thu, 23 Mar 2023 11:57:54 +0100 [thread overview]
Message-ID: <ZBwwsj9Z9Ej9ccHf@cormorant.local> (raw)
In-Reply-To: <20230320124042.1404-1-kozlowski.mateuszpl@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
On Mar 20 13:40, Mateusz Kozlowski wrote:
> Since the nvme_blk_read/write are used by both the data and metadata
> portions of the IO, it can't have the 512B alignment requirement.
> Without this change any metadata transfer, which length isn't a multiple
> of 512B and which is bigger than 512B, will result in only a partial
> transfer.
>
> Signed-off-by: Mateusz Kozlowski <kozlowski.mateuszpl@gmail.com>
Thanks Mateusz,
LGTM.
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-03-23 10:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 12:40 [PATCH] hw/nvme: Change alignment in dma functions for nvme_blk_* Mateusz Kozlowski
2023-03-23 10:57 ` Klaus Jensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBwwsj9Z9Ej9ccHf@cormorant.local \
--to=its@irrelevant.dk \
--cc=kbusch@kernel.org \
--cc=kozlowski.mateuszpl@gmail.com \
--cc=mateusz.kozlowski@solidigm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).