From: Peter Xu <peterx@redhat.com>
To: Lukas Straub <lukasstraub2@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Juan Quintela" <quintela@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>
Subject: Re: [PATCH 00/14] migration/ram.c: Refactor compress code
Date: Wed, 5 Apr 2023 10:54:45 -0400 [thread overview]
Message-ID: <ZC2Ltd8aZgj4L7Cl@x1n> (raw)
In-Reply-To: <20230405144413.67f0b505@gecko.fritz.box>
On Wed, Apr 05, 2023 at 02:44:13PM +0000, Lukas Straub wrote:
> On Sun, 2 Apr 2023 17:55:59 +0000
> Lukas Straub <lukasstraub2@web.de> wrote:
>
> > This series refactors the ram compress code.
> >
> > It first removes ram.c dependencies from the core compress code, then
> > moves it out to its own file. Finally, on the migration destination side
> > the initialisation and cleanup of compress threads is moved out of ram.c
> > to migration.c. This allows using COLO with compress enabled.
> >
> > This series is based on the following series:
> > https://lore.kernel.org/qemu-devel/af76761aa6978071c5b8e9b872b697db465a5520.1680457631.git.lukasstraub2@web.de/T/#t
> >
>
> Hmm, I'm wondering if I should add postcopy+compress tests in this
> series? Because if we start this, the test matrix really will explode.
Do you perhaps mean when compress added to the existing (and already large)
postcopy test matrix?
I assume we can still add one for vanilla postcopy+compress, so it still
covers the major parts. Or, add the compress test with the postcopy test
with most features enabled? The most comprehensive one in qtest should be:
/x86_64/migration/postcopy/preempt/recovery/tls/psk
That covers postcopy+preempt+tls, meanwhile there'll be an emulation of
network failure too during postcopy and test recovering from it.
--
Peter Xu
prev parent reply other threads:[~2023-04-05 14:55 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 17:55 [PATCH 00/14] migration/ram.c: Refactor compress code Lukas Straub
2023-04-02 17:56 ` [PATCH 01/14] ram.c: Let the compress threads return a CompressResult enum Lukas Straub
2023-04-03 7:25 ` Philippe Mathieu-Daudé
2023-04-03 10:59 ` Lukas Straub
2023-04-02 17:56 ` [PATCH 02/14] ram.c: Dont change param->block in the compress thread Lukas Straub
2023-04-02 17:56 ` [PATCH 03/14] ram.c: Reset result after sending queued data Lukas Straub
2023-04-02 17:56 ` [PATCH 04/14] ram.c: Do not call save_page_header() from compress threads Lukas Straub
2023-04-02 17:56 ` [PATCH 05/14] ram.c: Call update_compress_thread_counts from compress_send_queued_data Lukas Straub
2023-04-02 17:56 ` [PATCH 06/14] ram.c: Remove last ram.c dependency from the core compress code Lukas Straub
2023-04-02 17:56 ` [PATCH 07/14] ram.c: Introduce whitespace (squash with next patch) Lukas Straub
2023-04-02 17:56 ` [PATCH 08/14] ram.c: Move core compression code into its own file Lukas Straub
2023-04-02 17:56 ` [PATCH 09/14] ram.c: Remove whitespace (squash with previous patch) Lukas Straub
2023-04-02 17:56 ` [PATCH 10/14] ram.c: Move core decompression code into its own file Lukas Straub
2023-04-03 7:27 ` Philippe Mathieu-Daudé
2023-04-02 17:56 ` [PATCH 11/14] ram compress: Assert that the file buffer matches the result Lukas Straub
2023-04-02 17:56 ` [PATCH 12/14] ram.c: Remove unused include after moving out code Lukas Straub
2023-04-03 7:30 ` Philippe Mathieu-Daudé
2023-04-02 17:56 ` [PATCH 13/14] ram-compress.c: Make target independent Lukas Straub
2023-04-03 7:29 ` Philippe Mathieu-Daudé
2023-04-02 17:56 ` [PATCH 14/14] migration: Initialize and cleanup decompression in migration.c Lukas Straub
2023-04-03 2:16 ` [PATCH 00/14] migration/ram.c: Refactor compress code Zhang, Chen
2023-04-05 14:44 ` Lukas Straub
2023-04-05 14:54 ` Peter Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZC2Ltd8aZgj4L7Cl@x1n \
--to=peterx@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=lukasstraub2@web.de \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).