From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Konstantin Kostiuk <kkostiuk@redhat.com>
Cc: Kfir Manor <kfir@daynix.com>,
qemu-devel@nongnu.org, Michael Roth <michael.roth@amd.com>,
Yan Vugenfirer <yan@daynix.com>
Subject: Re: [PATCH v2] qga/linux: add usb support to guest-get-fsinfo
Date: Wed, 29 Mar 2023 14:04:02 +0100 [thread overview]
Message-ID: <ZCQ3Qkxg8fJg+EZ2@redhat.com> (raw)
In-Reply-To: <CAPMcbCosAhA5=rOgaMbkK9zAMuWQFXhb3_vVWy_WNPZ7s=Pqew@mail.gmail.com>
What's the status of this patch ? It was acked 2 months ago but
AFAICT it was never merged.
On Mon, Jan 23, 2023 at 10:42:06PM +0200, Konstantin Kostiuk wrote:
> Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
>
> On Mon, Jan 23, 2023 at 3:31 PM Kfir Manor <kfir@daynix.com> wrote:
>
> > Signed-off-by: Kfir Manor <kfir@daynix.com>
> > ---
> > qga/commands-posix.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> > index ebd33a643c..aab9d3bd50 100644
> > --- a/qga/commands-posix.c
> > +++ b/qga/commands-posix.c
> > @@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> > *syspath,
> > g_str_equal(driver, "sym53c8xx") ||
> > g_str_equal(driver, "virtio-pci") ||
> > g_str_equal(driver, "ahci") ||
> > - g_str_equal(driver, "nvme"))) {
> > + g_str_equal(driver, "nvme") ||
> > + g_str_equal(driver, "xhci_hcd") ||
> > + g_str_equal(driver, "ehci-pci"))) {
> > break;
> > }
> >
> > @@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const
> > *syspath,
> > }
> > } else if (strcmp(driver, "nvme") == 0) {
> > disk->bus_type = GUEST_DISK_BUS_TYPE_NVME;
> > + } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver,
> > "xhci_hcd") == 0) {
> > + disk->bus_type = GUEST_DISK_BUS_TYPE_USB;
> > } else {
> > g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath);
> > goto cleanup;
> > --
> > 2.38.1
> >
> >
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2023-03-29 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 13:30 [PATCH v2] qga/linux: add usb support to guest-get-fsinfo Kfir Manor
2023-01-23 20:42 ` Konstantin Kostiuk
2023-03-29 13:04 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCQ3Qkxg8fJg+EZ2@redhat.com \
--to=berrange@redhat.com \
--cc=kfir@daynix.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).