From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1E40C77B6F for ; Wed, 29 Mar 2023 13:05:56 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1phVTv-0006NK-Fw; Wed, 29 Mar 2023 09:04:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phVTt-0006MO-At for qemu-devel@nongnu.org; Wed, 29 Mar 2023 09:04:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phVTq-0006ck-03 for qemu-devel@nongnu.org; Wed, 29 Mar 2023 09:04:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680095083; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=sm0a0XB2iLISPAGcEc2aDeBHE3zidR7Jri0+7vqJZik=; b=g3yF5FIiYCLvU8l+ZujwJdoHzK2LmkYbI1w1gEeUElj8vNkpK9aHPAnBnB+p3zN1VdP0tb syVl45akphK35BtwhpSIiUpK9w/Eoyv+VNvzlsNnz1TyZEu3EJ9wqfKKxDO/p4Z+1+sVjO KVFywUft9MxYYZ/HgTNg3nOuBfOW4Ro= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-588-17BiOkMgNmO9CBDhWIybfg-1; Wed, 29 Mar 2023 09:04:29 -0400 X-MC-Unique: 17BiOkMgNmO9CBDhWIybfg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BE5393C11BC9; Wed, 29 Mar 2023 13:04:05 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.123]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C59901121331; Wed, 29 Mar 2023 13:04:04 +0000 (UTC) Date: Wed, 29 Mar 2023 14:04:02 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Konstantin Kostiuk Cc: Kfir Manor , qemu-devel@nongnu.org, Michael Roth , Yan Vugenfirer Subject: Re: [PATCH v2] qga/linux: add usb support to guest-get-fsinfo Message-ID: References: <20230123133049.1053505-1-kfir@daynix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org What's the status of this patch ? It was acked 2 months ago but AFAICT it was never merged. On Mon, Jan 23, 2023 at 10:42:06PM +0200, Konstantin Kostiuk wrote: > Reviewed-by: Konstantin Kostiuk > > On Mon, Jan 23, 2023 at 3:31 PM Kfir Manor wrote: > > > Signed-off-by: Kfir Manor > > --- > > qga/commands-posix.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > > index ebd33a643c..aab9d3bd50 100644 > > --- a/qga/commands-posix.c > > +++ b/qga/commands-posix.c > > @@ -880,7 +880,9 @@ static bool build_guest_fsinfo_for_pci_dev(char const > > *syspath, > > g_str_equal(driver, "sym53c8xx") || > > g_str_equal(driver, "virtio-pci") || > > g_str_equal(driver, "ahci") || > > - g_str_equal(driver, "nvme"))) { > > + g_str_equal(driver, "nvme") || > > + g_str_equal(driver, "xhci_hcd") || > > + g_str_equal(driver, "ehci-pci"))) { > > break; > > } > > > > @@ -977,6 +979,8 @@ static bool build_guest_fsinfo_for_pci_dev(char const > > *syspath, > > } > > } else if (strcmp(driver, "nvme") == 0) { > > disk->bus_type = GUEST_DISK_BUS_TYPE_NVME; > > + } else if (strcmp(driver, "ehci-pci") == 0 || strcmp(driver, > > "xhci_hcd") == 0) { > > + disk->bus_type = GUEST_DISK_BUS_TYPE_USB; > > } else { > > g_debug("unknown driver '%s' (sysfs path '%s')", driver, syspath); > > goto cleanup; > > -- > > 2.38.1 > > > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|