From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28D40C76196 for ; Fri, 31 Mar 2023 13:53:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piFBu-0007A4-3x; Fri, 31 Mar 2023 09:53:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piFBm-00077S-Fx; Fri, 31 Mar 2023 09:53:12 -0400 Received: from mail-yw1-x1131.google.com ([2607:f8b0:4864:20::1131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piFBk-0005qp-Tw; Fri, 31 Mar 2023 09:53:10 -0400 Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-5416698e889so416352247b3.2; Fri, 31 Mar 2023 06:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680270787; x=1682862787; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:from:to:cc:subject:date :message-id:reply-to; bh=TNnCkGapJJW2deY2FwRAI1TA6GA8JBnQAgxQXgsdp40=; b=e2MZEYU/fCEJRl2Ale1sS1WT6syo91r035W1fpB1RELOT9+vIbJQOtFgB5AMdbnPKf lFEz51d3GVuidyoB3UkRP+9AbMVAi7zKiXpT/+Sonq4rL1UIN3bu6uUSBTJEHuaTDLpw 5biVc+h/2WILfoGPYMbd72I8IwmuVCZ2cqXaAcHTruWEmZgBDsW+q58XydTT0dUs4uf0 t3QPntTk0gHTNWzM4+6k6bt+qQbQVVD8TNYWKLLvDi9ZvK1ccldJu95V3Ll1xdbjqBDP CG9B16dZGTQxKmDOKKOkKfVNvcRdeFjmDz5XUih6DuaS3AmUkjHlXK/WKdIun9zSMdNq vTEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680270787; x=1682862787; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TNnCkGapJJW2deY2FwRAI1TA6GA8JBnQAgxQXgsdp40=; b=3SN7+FZmx1BzhBYRzUDZwCVTAMnBIVZNx5o4hF0t3+nOICGhUrUjy1SgPQyrxUJon0 AdqanpTWua96T6AKL4DA8Tp+7Fzdvtz1z4DhaCfA34w1CfDboDL3J/oQ53r3WsihJCW2 iUzaNCOFZNZ2Akl6Ed9KGE4QecvDqyM/Q76wN/6JHD8LVkxeIcal7Z2jrN30T62Cy+Z9 /nyeKLvDBW2Sz6PETHDd9sZnRCFqmZMJAeWwsMlphTdyILrO1OTJ19DJ9fMfgwOC4o+0 NEiPRnXGlsIWGTNwp3nh5UDPuVwzf5trHRVNdiFv9tpU+1oahM8Tkn0FF2P6Rz3O8uO+ ZCMw== X-Gm-Message-State: AAQBX9dpexfsvqT6RcEc/HniMbgOdHJ5MFTPx8P9/nCEhWRQ2ku/NBMs BWD2YQNezwA6XCjqUBFIZQ== X-Google-Smtp-Source: AKy350ZecvekwDxvc7CsT7oqZ8qCf2qfXim86Pi1jiH9tIyvvaZDbEN+1OgKgNQMjl+8IWyu/qY0ug== X-Received: by 2002:a81:a209:0:b0:545:91c2:d5eb with SMTP id w9-20020a81a209000000b0054591c2d5ebmr24582598ywg.28.1680270786987; Fri, 31 Mar 2023 06:53:06 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id a6-20020a814d06000000b00545a08184efsm528678ywb.127.2023.03.31.06.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 06:53:06 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:4b5:7e28:63da:3be]) by serve.minyard.net (Postfix) with ESMTPSA id 9B2B01800BB; Fri, 31 Mar 2023 13:53:05 +0000 (UTC) Date: Fri, 31 Mar 2023 08:53:04 -0500 From: Corey Minyard To: Titus Rwantare Cc: philmd@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, Patrick Venture Subject: Re: [PATCH 4/7] hw/i2c: pmbus: block uninitialised string reads Message-ID: References: <20230331000756.1712787-1-titusr@google.com> <20230331000756.1712787-5-titusr@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230331000756.1712787-5-titusr@google.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::1131; envelope-from=tcminyard@gmail.com; helo=mail-yw1-x1131.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Mar 31, 2023 at 12:07:53AM +0000, Titus Rwantare wrote: > Devices models calling pmbus_send_string can't be relied upon to > send a non-zero pointer. This logs an error and doesn't segfault. > > Reviewed-by: Patrick Venture > Signed-off-by: Titus Rwantare Acked-by: Corey Minyard > --- > hw/i2c/pmbus_device.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/hw/i2c/pmbus_device.c b/hw/i2c/pmbus_device.c > index bb42e410b4..18e629eaac 100644 > --- a/hw/i2c/pmbus_device.c > +++ b/hw/i2c/pmbus_device.c > @@ -94,6 +94,13 @@ void pmbus_send64(PMBusDevice *pmdev, uint64_t data) > > void pmbus_send_string(PMBusDevice *pmdev, const char *data) > { > + if (!data) { > + qemu_log_mask(LOG_GUEST_ERROR, > + "%s: %s: uninitialised read from 0x%02x\n", > + __func__, DEVICE(pmdev)->canonical_path, pmdev->code); > + return; > + } > + > size_t len = strlen(data); > g_assert(len + pmdev->out_buf_len < SMBUS_DATA_MAX_LEN); > pmdev->out_buf[len + pmdev->out_buf_len] = len; > -- > 2.40.0.423.gd6c402a77b-goog >