From: Peter Xu <peterx@redhat.com>
To: Lukas Straub <lukasstraub2@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH RESEND 2/2] migration/ram.c: Fix migration with compress enabled
Date: Mon, 3 Apr 2023 17:19:40 -0400 [thread overview]
Message-ID: <ZCtC7OTHLg0u9c09@x1n> (raw)
In-Reply-To: <f0cbd720150d72951e1cafe88ba75e853993f359.1680457631.git.lukasstraub2@web.de>
On Sun, Apr 02, 2023 at 05:48:38PM +0000, Lukas Straub wrote:
> Since ec6f3ab9, migration with compress enabled was broken, because
> the compress threads use a dummy QEMUFile which just acts as a
> buffer and that commit accidentally changed it to use the outgoing
> migration channel instead.
Sorry. :(
> Fix this by using the dummy file again in the compress threads.
>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Let's also add a Fixes tag to be clear:
ec6f3ab9f4 ("migration: Move last_sent_block into PageSearchStatus")
Even though it may not need to copy stable.
I think this is for 8.0, am I right? It should be very clear if so,
otherwise it's easy to get overlooked.
--
Peter Xu
next prev parent reply other threads:[~2023-04-03 21:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-02 17:47 [PATCH RESEND 1/2] qtest/migration-test.c: Add test with compress enabled Lukas Straub
2023-04-02 17:48 ` [PATCH RESEND 2/2] migration/ram.c: Fix migration " Lukas Straub
2023-04-03 21:19 ` Peter Xu [this message]
2023-04-03 21:17 ` [PATCH RESEND 1/2] qtest/migration-test.c: Add test " Peter Xu
2023-04-04 7:40 ` Lukas Straub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCtC7OTHLg0u9c09@x1n \
--to=peterx@redhat.com \
--cc=dgilbert@redhat.com \
--cc=lukasstraub2@web.de \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).