From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v3] test: Fix test-crypto-secret when compiling without keyring support
Date: Tue, 18 Apr 2023 17:24:14 +0100 [thread overview]
Message-ID: <ZD7ELuuL6VGl1Rqe@redhat.com> (raw)
In-Reply-To: <20230414114252.1136-1-quintela@redhat.com>
On Fri, Apr 14, 2023 at 01:42:52PM +0200, Juan Quintela wrote:
> Linux keyring support is protected by CONFIG_KEYUTILS.
> We also need CONFIG_SECRET_KEYRING.
>
> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> ---
>
> - Previous version of this patch changed the meson build rules.
> Daniel told me that the proper fix was to change the #ifdef test.
>
> - Change rule again. We need both defines.
> - Put both defines in #endif (thomas)
> ---
> tests/unit/test-crypto-secret.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2023-04-18 16:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 11:42 [PATCH v3] test: Fix test-crypto-secret when compiling without keyring support Juan Quintela
2023-04-18 16:24 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD7ELuuL6VGl1Rqe@redhat.com \
--to=berrange@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).