From: Peter Xu <peterx@redhat.com>
To: Juan Quintela <quintela@redhat.com>
Cc: qemu-devel@nongnu.org, Leonardo Bras <leobras@redhat.com>
Subject: Re: [PATCH v3 00/12] Migration: Make more ram_counters atomic
Date: Wed, 19 Apr 2023 15:29:23 -0400 [thread overview]
Message-ID: <ZEBBDlcGuVxOGQOt@x1n> (raw)
In-Reply-To: <20230419162415.16260-1-quintela@redhat.com>
On Wed, Apr 19, 2023 at 06:24:03PM +0200, Juan Quintela wrote:
> Juan Quintela (12):
> migration: Merge ram_counters and ram_atomic_counters
> migration: Update atomic stats out of the mutex
> migration: Make multifd_bytes atomic
> migration: Make dirty_sync_missed_zero_copy atomic
> migration: Make precopy_bytes atomic
> migration: Make downtime_bytes atomic
> migration: Make dirty_sync_count atomic
> migration: Make postcopy_requests atomic
> migration: Make dirty_pages_rate atomic
> migration: Make dirty_bytes_last_sync atomic
> migration: Rename duplicate to zero_pages
> migration: Rename normal to full_pages
Reviewed-by: Peter Xu <peterx@redhat.com>
One trivial comment on last patch: full_pages is slightly confusing to me,
probably because "normal" matches with the code (save_normal_page()),
meanwhile "full" makes me think of small/huge page where it can be a
huge/full page (comparing to a "partial" page).
I'd think "normal_pages" could be slightly better? No strong opinions
though.
--
Peter Xu
next prev parent reply other threads:[~2023-04-19 19:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-19 16:24 [PATCH v3 00/12] Migration: Make more ram_counters atomic Juan Quintela
2023-04-19 16:24 ` [PATCH v3 01/12] migration: Merge ram_counters and ram_atomic_counters Juan Quintela
2023-04-19 16:24 ` [PATCH v3 02/12] migration: Update atomic stats out of the mutex Juan Quintela
2023-04-19 16:24 ` [PATCH v3 03/12] migration: Make multifd_bytes atomic Juan Quintela
2023-04-19 16:24 ` [PATCH v3 04/12] migration: Make dirty_sync_missed_zero_copy atomic Juan Quintela
2023-04-19 16:24 ` [PATCH v3 05/12] migration: Make precopy_bytes atomic Juan Quintela
2023-04-19 16:24 ` [PATCH v3 06/12] migration: Make downtime_bytes atomic Juan Quintela
2023-04-19 16:24 ` [PATCH v3 07/12] migration: Make dirty_sync_count atomic Juan Quintela
2023-04-19 16:24 ` [PATCH v3 08/12] migration: Make postcopy_requests atomic Juan Quintela
2023-04-19 16:24 ` [PATCH v3 09/12] migration: Make dirty_pages_rate atomic Juan Quintela
2023-04-19 16:24 ` [PATCH v3 10/12] migration: Make dirty_bytes_last_sync atomic Juan Quintela
2023-04-19 16:24 ` [PATCH v3 11/12] migration: Rename duplicate to zero_pages Juan Quintela
2023-04-19 16:24 ` [PATCH v3 12/12] migration: Rename normal to full_pages Juan Quintela
2023-04-19 19:29 ` Peter Xu [this message]
2023-04-19 19:54 ` [PATCH v3 00/12] Migration: Make more ram_counters atomic Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEBBDlcGuVxOGQOt@x1n \
--to=peterx@redhat.com \
--cc=leobras@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).